Enigmatica2Expert icon indicating copy to clipboard operation
Enigmatica2Expert copied to clipboard

Advanced Rocketry Fuel Loader only accepts Advanced Rocketry Rocket Fuel

Open BranDynamite opened this issue 3 years ago • 23 comments

Modpack version 1.83

Issue The Crystallizer Multiblock no longer require 2 coils but instead a fluid input hatch and a fluid output hatch in place of the coils

Logs https://i.imgur.com/DA0mlro.png

BranDynamite avatar Aug 25 '21 01:08 BranDynamite

Also the Rolling machine multiblock is just broken, all the block placements are completely messed up

BranDynamite avatar Aug 25 '21 03:08 BranDynamite

Sounds like it just changed? Do they still work? Possible duplicate of #1943

NielsPilgaard avatar Aug 25 '21 04:08 NielsPilgaard

well maybe it has been changed, but the crystallizer does not have any fluid crafting recipes. The crystallizer and rolling machine still work. Also I don't know if I should make a separate issue for this, but the fuel loader isn't accepting any liquids

BranDynamite avatar Aug 25 '21 04:08 BranDynamite

Hmm, sounds like a separate issue, I'll change this one to the Fuel Loader thingie.

NielsPilgaard avatar Aug 25 '21 05:08 NielsPilgaard

The Rocket Fluid loader does accept fluids, I can't reproduce the issue.

billede billede

NielsPilgaard avatar Aug 25 '21 11:08 NielsPilgaard

Are you on version 1.83? Also I do not see any of the side configs in the gui. Here are some screenshots showing the fuel loader not accepting liquid oxygen or starlight https://i.imgur.com/E1UaiEd.png https://i.imgur.com/Bfna9Kj.png

BranDynamite avatar Aug 25 '21 14:08 BranDynamite

Yes I'm on version 1.83 Are you using the Rocket Fuel Loader? The Fuel Station label in the screenshots suggest otherwise.

NielsPilgaard avatar Aug 25 '21 15:08 NielsPilgaard

actually I meant to say fueling station, as you cannot load fuel into the rocket using the rocket fluid loader

BranDynamite avatar Aug 25 '21 17:08 BranDynamite

I wonder what the Rocket Fluid Loader does :P

You are sorta correct, the Fueling Station only accepts Advanced Rocketry Rocket Fuel at the moment, it should accept more.

NielsPilgaard avatar Aug 25 '21 17:08 NielsPilgaard

Is there a config file for what fuels it accepts?

BranDynamite avatar Aug 25 '21 18:08 BranDynamite

Yep, see here: https://github.com/NillerMedDild/Enigmatica2Expert/commit/86b75b776198b7a43ac3eb1bfdddd431510c6503

NielsPilgaard avatar Aug 25 '21 19:08 NielsPilgaard

Outputs the following with above fix:

[19:28:15] [Server thread/INFO] [advancedrocketry]: Start registering liquid rocket fuels
[19:28:15] [Server thread/INFO] [advancedrocketry]: Registering fluid rocketfuel;2 as rocket monopropellant
[19:28:15] [Server thread/WARN] [advancedrocketry]: Fluid namerefinedfuel;2 is not a registered fluid!
[19:28:15] [Server thread/INFO] [advancedrocketry]: Registering fluid pyrotheum;2 as rocket monopropellant
[19:28:15] [Server thread/INFO] [advancedrocketry]: Registering fluid neutron;8 as rocket monopropellant
[19:28:15] [Server thread/INFO] [advancedrocketry]: Registering fluid ic2uu_matter;16 as rocket monopropellant
[19:28:15] [Server thread/WARN] [advancedrocketry]: Fluid nameliquidstarlight;3 is not a registered fluid!
[19:28:15] [Server thread/INFO] [advancedrocketry]: Registering fluid hydrogen as rocket bipropellant
[19:28:15] [Server thread/INFO] [advancedrocketry]: Registering fluid oxygen as rocket oxidizer
[19:28:15] [Server thread/INFO] [advancedrocketry]: Finished registering liquid rocket fuels

With that, liquid starlight and refined fuel do not work.

Also, I'm not familiar with AR, but shouldn't liquid oxygen work, too? image

msparkles avatar Aug 27 '21 11:08 msparkles

Correct config:

S:rocketFuels <
    rocketfuel;2
    refined_fuel;2
    pyrotheum;2
    neutron;8
    ic2uu_matter;16
    astralsorcery.liquidstarlight;3
 >

msparkles avatar Aug 27 '21 11:08 msparkles

I can load blazing pyrotheum no problem but cant fly to luna with a rocket

AntsForBreakfast avatar Sep 25 '21 12:09 AntsForBreakfast

The corrected config leaves out Mekanism Liquid Oxygen, which the questbook mentions you can use.

dooms247 avatar Sep 30 '21 20:09 dooms247

I did ask about Liquid Oxygen, but it remained unanswered

msparkles avatar Oct 01 '21 06:10 msparkles

Right, I'll get that re-added too :)

NielsPilgaard avatar Oct 01 '21 18:10 NielsPilgaard

has this been addressed at all? Having just gotten into advanced rocketry I'm wondering, if the server owner adds in the fix mentioned above to the server config, will it work?

Terra-B-Welch avatar Jan 24 '22 08:01 Terra-B-Welch

has this been addressed at all? Having just gotten into advanced rocketry I'm wondering, if the server owner adds in the fix mentioned above to the server config, will it work?

It will yes.

NielsPilgaard avatar Jan 24 '22 08:01 NielsPilgaard

Question about this: The original mod uses the electrolyser to create hydrogen and oxygen, then you have two options: Create the bipropellant engine and use both the liquid hydrogen and the liquid oxygen to fly, or use the chemical reactor to create rocket fuel for the monopropellant engine. I saw above that you were planning on adding oxygen in as a viable fuel like the other fuels. Was the intention in this modpack to change the default behavior to an easier behavior, so that only liquid oxygen is needed as a monopropellant? Or was the intention to use liquid oxygen + hydrogen as a bipropellant fuel? The config file lists hydrogen as the only viable bipropellant fuel, so the liquid oxygen may need to be added there rather than the rocket fuels list mentioned by Mg138 (a few lines above it).

If the intention is to have the oxygen be a bipropellant fuel, I recommend changing the QuestBook to clarify that Liquid Oxygen and Hydrogen are viable bipropellant fuels, and either recommending that the player visit the wiki (http://arwiki.dmodoomsirius.me/AdvancedRocketry/1.12.2/blocks/RocketEngine.php) or adding this line into the QuestBook (directly from the wiki): There are two types of engines each with a basic and advanced engine. Monopropellant uses 2 mB/t of rocket fuel. Bipropellant uses 1mB/t each of hydrogen and oxygen and requires 1 of each tank on the rocket.

Please also note that if the intention is to have the player use the bipropellant engine, this requires more titanium, which will likely force the player to use the Advanced Metallurgic Fabricator from Modular Machinery.

Thank you so much, I love your pack!

The Official Advanced Rocketry Wiki

Arithmion avatar Feb 06 '22 17:02 Arithmion

Iirc the bipropellant engine wasn't implemented when we made the quests :P Sounds like liquid oxygen shouldn't be a viable monopropellant fuel now, we'll get that sorted 👍... one day, hopefully

NielsPilgaard avatar Feb 07 '22 18:02 NielsPilgaard

After further research, I learned that the bipropellant fuel list is only supposed to contain hydrogen, and the oxidizer is in a separate list a few lines below it. So as it stands now, nothing is needed to make liquid oxygen work with bipropellant engines, but it still doesn't work as a monopropellant of course. (The mekanism oxygen doesn't work, only the nuclearcraft/AdvRocketry.) Seeing as this is the case, I would personally suggest removing the liquid oxygen from the questbook list of monopropellant fuels completely, now that bipropellant has been added, and just implementing Mg138's suggestion. Sorry for any obnoxiousness my previous post caused!

Arithmion avatar Feb 10 '22 22:02 Arithmion

Correct config:

S:rocketFuels <
    rocketfuel;2
    refined_fuel;2
    pyrotheum;2
    neutron;8
    ic2uu_matter;16
    astralsorcery.liquidstarlight;3
 >

I updated my advancedRocketry.cfg and restarted my server but the fueling station still doesn't take astral starlight? v1.83 of the modpack.

Edit: Originally I used this: https://github.com/EnigmaticaModpacks/Enigmatica2Expert/commit/86b75b776198b7a43ac3eb1bfdddd431510c6503 But what is pasted above works

toastonrye avatar Mar 05 '22 05:03 toastonrye

Hello there,

i just found this threat before i was reporting the issue with the rocket fuels in 1.83. Since i found out yesterday that the rockets vom AR only accept the AR rocket fuel, i was testing things out and looked into my old E2E Versions (1.79a for example).

If you replace the following lines in the AR config for the accepted fuels, all the mentioned fuels will work again in 1.83:


List of fluid names for fluids that can be used as rocket fuel

S:rocketFuels <
    rocketfuel
    rocket_fuel
    refined_fuel
    pyrotheum
    neutron
    liquidoxygen
    ic2uu_matter
    astralsorcery.liquidstarlight
 >

I dont know if the ";" als delimiter is a problem. This needs to be tested still, but the lines ive posted work 100% :)

/cheers

GrimReaper1982 avatar Sep 11 '22 10:09 GrimReaper1982