WorldEdit When setting/pasting/etc., blocks are missing or partially connected (NOT default states)

When setting/pasting/etc., blocks are missing or partially connected (NOT default states)

Open Tsoccerguy3 opened this issue 4 years ago • 18 comments

Versions

WorldEdit version: build 5093 Platform version: Spigot 1.16.1

Describe the bug

The block states of wall , glass panes and fences are not maintained when copied , then flipped and pasted

To Reproduce

... select pos1 and pos2
... //copy 3... //flip 4... //paste Expected behavior

expect to have a mirrored block state of the blocks and connectivity maintained

Screenshots

2020-06-27_14 06 58 2020-06-27_14 07 06 Additional context

Jun 27 '20 19:06 Tsoccerguy3

Probably need to use //perf validation off

Jun 27 '20 19:06 octylFractal

2020-06-27_15 10 19

that worked , but in gamemode 1 , left click select pos1 causes the block to change its state 2020-06-27_15 14 03

Jun 27 '20 19:06 Tsoccerguy3

that's a server side bug.

Jun 27 '20 19:06 wizjany

you mean a spigot error?

Jun 27 '20 19:06 Tsoccerguy3

Also does every player need to do //perf off or is it a config setting

Jun 27 '20 19:06 Tsoccerguy3

It's per-player, and doesn't retain over sessions.

The block state change is because the block "breaks" but is then restored by the server / client somehow. I don't really know if it's a Spigot bug in particular, it happens on all modded platforms when a block break is cancelled. Heck, even vanilla might have it for some of the protection stuff.

Jun 27 '20 19:06 octylFractal

In 1.16 they added a bunch of new "parameters", such as "tall", "none", and "low" for walls. Any copies, pastes, replaces, etc. don't work I am assuming because the plugin does not understand those parameters. I figured I would mention it here rather than do another issue thing just as a sorta fyi

Jul 02 '20 05:07 VoltroXP

WorldEdit gets the properties from the platform, it can't "not know" about them

Jul 02 '20 05:07 me4502

I also have this problem! it's so annoying having to replace and fix all the blocks in a big building! :<(

Jul 04 '20 21:07 Ranzer27

Will they fix this bug in the upcoming release for 1.16+?

Jul 04 '20 21:07 Ranzer27

We've already "fixed" it, by disabling the validation side-effect. You can do it for yourself with the command I already wrote, //perf validation off. This is left open as a reminder for us to look into potentially improving how it works for 7.2.0.

As for "will they fix this", you can answer that question yourself by looking at the milestone we've attached to the issue. This indicates that we have plans to fix this in some way by 7.2.0.

Jul 04 '20 22:07 octylFractal

Unsure if it's the same bug, but it seems to be affecting rails as well, which don't always retain the same directions from the copy to the paste. Inconsistent results (sometimes it's fine, sometimes not) and mostly seems to affect curved rails more. Currently on 7.2.0 beta 2 with git-Spigot-c3a49df-b0c6dfe.

Jul 12 '20 18:07 mercurialmusic

Rails are actually a part of #1416, see https://github.com/EngineHub/WorldEdit/issues/1416#issuecomment-653715662 especially. Rails use the same mechanism to update as observers, for some reason.

Jul 12 '20 19:07 octylFractal

We are having this issue too