CraftBook icon indicating copy to clipboard operation
CraftBook copied to clipboard

Determine smeltable items dynamically (for pipes inputting items into furnaces)

Open ANRAR4 opened this issue 9 months ago • 3 comments

As previously suggested in #1344 the changes replace the switch case statements for determining items smeltable and cookable inside a furnace, which are used to check if an item can be put inside a furnace, with comparisons to lists of the available smelting/cooking/blastsmelting recipes, as the hardcoded lists tend to be outdated.

ANRAR4 avatar Mar 30 '25 15:03 ANRAR4

This PR currently deadlocks my test server during startup. That would need to be fixed before this can be considered.

me4502 avatar Apr 26 '25 06:04 me4502

During my testing I didn't encounter any problems What configuration etc. does your server use?

ANRAR4 avatar Apr 26 '25 13:04 ANRAR4

Firstly, I rebased this on top of current master. Then I ran it on a default-settings Paper server with the 1.21.5 build number 36. The only plugins installed were WorldEdit, WorldGuard, LuckPerms, Vault, and this built PR of CraftBook.

What specifically happens is the server stops responding, and starts consuming all available memory (32GB, in this case). It then ends up stalled in GC threads, preventing even the watchdog from killing the server due to the stall.

me4502 avatar Apr 26 '25 13:04 me4502