Flywheel icon indicating copy to clipboard operation
Flywheel copied to clipboard

[1.20.1] [0.6.10-7] Block colors not working if not in instancing mode

Open hlysine opened this issue 1 year ago • 0 comments

Describe the Bug

Hi, Create: Copycats+ dev again. This is another issue with the Copycat Shaft, where it seems that block colors don't get rendered when using the batching backend or when Flywheel is off. I have checked that the correct colors are definitely provided in our custom BlockColor and BlockAndTintGetter implementations, but grass still looks gray if the active flywheel backend is not instancing. Sorry if this one ends up to be a bug in C:Copycats+, but the fact that only instancing works makes it even more confusing.

If it's related, here are the relevant sections of C:Copycats+ code:

  • BlockColor implementation: https://github.com/copycats-plus/copycats/blob/6a5f7d253f9925a82f5b2738c5ec796ecad33f90/common/src/main/java/com/copycatsplus/copycats/content/copycat/base/functional/IFunctionalCopycatBlock.java#L255-L268
  • getBlockTint in our BlockAndTintGetter wrapper: https://github.com/copycats-plus/copycats/blob/6a5f7d253f9925a82f5b2738c5ec796ecad33f90/common/src/main/java/com/copycatsplus/copycats/content/copycat/base/model/functional/WrappedRenderWorld.java#L147-L151
  • Helper that generates buffered data: https://github.com/copycats-plus/copycats/blob/6a5f7d253f9925a82f5b2738c5ec796ecad33f90/common/src/main/java/com/copycatsplus/copycats/content/copycat/base/model/functional/FunctionalCopycatRenderHelper.java
  • Forge implementation: https://github.com/copycats-plus/copycats/blob/6a5f7d253f9925a82f5b2738c5ec796ecad33f90/forge/src/main/java/com/copycatsplus/copycats/content/copycat/base/model/functional/forge/FunctionalCopycatRenderHelperImpl.java
  • Fabric implementation: https://github.com/copycats-plus/copycats/blob/6a5f7d253f9925a82f5b2738c5ec796ecad33f90/fabric/src/main/java/com/copycatsplus/copycats/content/copycat/base/model/functional/fabric/FunctionalCopycatRenderHelperImpl.java

Reproduction Steps

  1. Download this test version of C:Copycats+ or build https://github.com/copycats-plus/copycats/tree/6a5f7d253f9925a82f5b2738c5ec796ecad33f90 from source: UNZIP Copycats-forge.1.20.1-1.3.5-shaft-TEST.6a5f7d2.zip UNZIP Copycats-fabric.1.20.1-1.3.5-shaft-TEST.6a5f7d2.zip

  2. Place a Copycat Shaft and place grass inside

  3. Switch flywheel backend and observe the grass color

Expected Result

The grass should always appear green and should always look like grass in plains biome.

Screenshots and Videos

image image image

Crash Report or Log

No response

Operating System

Windows 11

What is your GPU?

NVIDIA GeForce GTX 1650/PCIe/SSE2 4.6.0 NVIDIA 537.13

Mod Version

0.6.8.a

Minecraft Version

1.19.2

Loader Version

Forge 47.2.20, Fabric 0.15.7

Other Mods

(From dev environment)

Mod List: 
		forge-1.20.1-47.2.20-minecraft-merged-1.20.1-loom.|Minecraft                     |minecraft                     |1.20.1              |DONE      |Manifest: NOSIGNATURE
		mixinextras-forge-0.3.2.jar                       |MixinExtras                   |mixinextras                   |0.3.2               |DONE      |Manifest: NOSIGNATURE
		5490499978021441488.jar                           |generated_7dfba9c             |generated_7dfba9c             |1                   |DONE      |Manifest: NOSIGNATURE
		additional-placements-674852-5142065.jar          |Additional Placements         |additionalplacements          |1.8.0               |DONE      |Manifest: NOSIGNATURE
		                                                  |Forge                         |forge                         |47.2.20             |DONE      |Manifest: NOSIGNATURE
		rubidium-574856-4952685.jar                       |Rubidium                      |rubidium                      |0.7.1a              |DONE      |Manifest: NOSIGNATURE
		flywheel-forge-1.20.1-0.6.10-7.jar                |Flywheel                      |flywheel                      |0.6.10-7            |DONE      |Manifest: NOSIGNATURE
		jade-324717-5390389.jar                           |Jade                          |jade                          |11.9.3+forge        |DONE      |Manifest: NOSIGNATURE
		create-1.20.1-0.5.1.f-26-slim.jar                 |Create                        |create                        |0.5.1.f-26          |DONE      |Manifest: NOSIGNATURE
		main                                              |Create: Copycats+             |copycats                      |1.20.1-1.3.5-shaft-T|DONE      |Manifest: NOSIGNATURE
		jei-1.20.1-forge-15.3.0.4.jar                     |Just Enough Items             |jei                           |15.3.0.4            |DONE      |Manifest: NOSIGNATURE

Additional Context

No response

hlysine avatar Jun 26 '24 05:06 hlysine