Flywheel icon indicating copy to clipboard operation
Flywheel copied to clipboard

[Fabric] Incompatibility with Immersive Portals

Open AeiouEnigma opened this issue 3 years ago • 2 comments

Copy of https://github.com/Fabricators-of-Create/Create/issues/53 and https://github.com/qouteall/ImmersivePortalsMod/issues/967, opened here at the recommendation of qouteall.

Extraordinary rendering issues occur when looking through an Immersive Portal while the Fabric version of Create is installed.

2022-01-22_15 57 10

Really I'm just hoping that by opening an issue here, maybe Jozufozu or Pepper can share some insight into what the cause of the issue could be.

AeiouEnigma avatar Jan 25 '22 02:01 AeiouEnigma

Flywheel destroy all GL resources when ImmPtl create another client world

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/mixin/LevelRendererMixin.java#L92

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/Flywheel.java#L68

Flywheel can make that event triggered in Minecraft.updateLevelInEngines so that it won't trigger when ImmPtl creates secondary client world and secondary world renderer. (But that solution is not perfect, it still needs to reset when reloading resourcepacks) On immptl's side I can use hacky mixin to fix it temporarily.

qouteall avatar May 14 '22 07:05 qouteall

Flywheel destroy all GL resources when ImmPtl create another client world

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/mixin/LevelRendererMixin.java#L92

https://github.com/Jozufozu/Flywheel/blob/1.18%2Ffabric%2Fdev/src/main/java/com/jozufozu/flywheel/Flywheel.java#L68

Flywheel can make that event triggered in Minecraft.updateLevelInEngines so that it won't trigger when ImmPtl creates secondary client world and secondary world renderer. (But that solution is not perfect, it still needs to reset when reloading resourcepacks) On immptl's side I can use hacky mixin to fix it temporarily.

Does it also do this on Forge, or is this just how it was done on Fabric?

Nolij avatar May 14 '22 12:05 Nolij