gitprompt icon indicating copy to clipboard operation
gitprompt copied to clipboard

Add support for SVN

Open craigtmoore opened this issue 7 years ago • 6 comments

I've reformatted the file (resolved tabs and spaces) and also added support for SVN.

craigtmoore avatar Nov 20 '18 04:11 craigtmoore

Hello! I'm very happy that you decided to contribute! I've never used pull requests before, so I'm not sure how this works, but I'm definitely interested in what you've done. I'll see if maybe I can accept your pull request into the develop branch (or something) so I can check it out before I merge it into master also?

Enfors avatar Nov 20 '18 22:11 Enfors

Also, I'm very thankful you cleared up the tabs vs spaces issue - I didn't know I had tabs in there. Emacs is going to get a stern talking-to, because this is just embarrassing.

Enfors avatar Nov 20 '18 22:11 Enfors

Okay, I figured out how to test your version now, and I have some issues with it:

  • It seems you've removed the brackets around the time. I prefer to have them there, but I can make that configurable, so that you can disable them on your end. Does that sound okay?
  • Also, it seems that the actual git status part doesn't work anymore (it doesn't show up); I suspect you haven't tested that? Could you perhaps have a look at that? If you don't have a git repo to test with, just make an empty directory and type "git init" inside it, that should be enough for basic testing.

Enfors avatar Nov 20 '18 23:11 Enfors

Yeah we can configure the format somehow. I'll try to work it out. The git was working for my on my end, but maybe I have some outstanding commits on my end. I'll look into it.

craigtmoore avatar Nov 20 '18 23:11 craigtmoore

This is what I see on my end. The first folder is my svn repo for my scripts. And the second is the directory where I have the gitprompt code checked in.

18:41 wsi@ubuntu ~/bin [trunk]: Untracked, Modified
$ cd /home/wsi/dev/workspace-gitprompt

18:41 wsi@ubuntu ~/dev/workspace-gitprompt [master]: Untracked
$

Note: the untracked file is my IntelliJ project file.

craigtmoore avatar Nov 20 '18 23:11 craigtmoore

Out of curiosity, how did you try out my changes did you merge them into your branch locally or did you switch to my branch?

craigtmoore avatar Nov 20 '18 23:11 craigtmoore