dicom-rs icon indicating copy to clipboard operation
dicom-rs copied to clipboard

Published 20 hours ago • verified publisher icon Enet4

Store SCP

Open vsaase opened this issue 3 years ago • 2 comments

Hi, I made this quick example of a C-STORE SCP. Would be happy for comments.

vsaase avatar Jan 03 '22 22:01 vsaase

needs some work to fill the proper File Meta Information before saving to disk

vsaase avatar Jan 04 '22 21:01 vsaase

Thank you for this neat contribution! It has already helped me diagnose some issues in the ul crate.

One thing that intrigues me here: is there something missing in the AssociationServer abstraction that led you towards reading and writing PDUs on your own? It was originally pictured that SCPs would use either the ul::association module or something at a higher level of abstraction. It might be worth filling the gaps here rather than building the association logic from scratch.

One thing I see is that while PDataWriter exists, PDataReader does not. And it would be useful here in order to accumulate the sequence of PData values. Just filed #216. If there are other pain points, I would love to know.

I am happy you found it useful. I just didn't know about the AssociationServer abstraction at that time, I just looked at some of the other examples.

vsaase avatar Jan 31 '22 20:01 vsaase

I have been reiterating on the store SCP, but now that my branch is rebased, I will need to commandeer this with a new pull request. Your baseline is still very much appreciated!

#296

Enet4 avatar Oct 15 '22 14:10 Enet4