magisk icon indicating copy to clipboard operation
magisk copied to clipboard

Android 11 magisk module path changed

Open slabua opened this issue 5 years ago • 4 comments

The following line should be update as follows: https://github.com/EnergizedProtection/magisk/blob/1c597d7fcd12581453077c2e76657e0a1e3a9b8f/system/bin/energized#L12 modPath="/data/adb/modules/energizedprotection/system/bin"

slabua avatar Sep 12 '20 00:09 slabua

This affects only those devices with the Android 11 installed right? If yes, we should additionally check for Android version before changing the modPath variable.

AvinashReddy3108 avatar Sep 12 '20 03:09 AvinashReddy3108

I think sbin/.magisk is/was a reference to the actual real path which was /data/adb/modules also in previous versions. So linking to the original path should not break previous versions.

Better way possibly, let the script itself find out its own location.

slabua avatar Sep 12 '20 06:09 slabua

Magisk has been in /data/adb for a while now

LoganDark avatar Nov 30 '20 17:11 LoganDark

I think sbin/.magisk is/was a reference to the actual real path which was /data/adb/modules also in previous versions. So linking to the original path should not break previous versions.

Better way possibly, let the script itself find out its own location.

This snippet does help us find the location, feel free to check it out.

https://github.com/EnergizedProtection/magisk/commit/5bf49bebc0612d06920a680b184e22e7e6972539#diff-146a351e388ce71d7689e634b5d8c2c5b990117edf8317b4febf68dd0d99c405R10-R18

AvinashReddy3108 avatar Dec 01 '20 04:12 AvinashReddy3108