TabPageViewController icon indicating copy to clipboard operation
TabPageViewController copied to clipboard

Can't set different background color in NavigationBar and TabBar

Open hayashikun opened this issue 8 years ago • 5 comments

I want to set different background color in NavigationBar and TabBar. However, I can't since NavigationBar background is set in this method. https://github.com/EndouMari/TabPageViewController/blob/master/Pod/Classes/TabPageViewController.swift#L123

I think NavigationBar background setting should not be done in TabPageViewController.

Have any solution to this?

hayashikun avatar Apr 16 '16 15:04 hayashikun

Thanks for opening the issue!

I'm still thinking of a solution. The Problem is the NavigationBar's 1 px line stands out, so I am not sure how to deal with that for the time being. It's difficult to remove the 1px line, but if you know a way to fix that issue please feel free to send a pull request!

In the meantime I will think of a solution, thanks!

EndouMari avatar Apr 16 '16 17:04 EndouMari

Hi EndouMari, How I can custom Navigation Bar 's appearance? I dont want to change in source code file. Maybe you should to stop updateNavigation() and The NavigationBar's 1 px is handle outside your source.

kaka09 avatar Jul 14 '16 06:07 kaka09

I think @kaka09 was right. For me, I need 1px shadow of NavigationBar. So, I must use my own forked version.

9you avatar Mar 31 '17 11:03 9you

I see this problem too. This occur because author always setup tabBackgroundImage that overlay navigationBar background color example_image Author setup same color for statusBar + navigationBar + tabBar at the same time I think author should have one more option to use tabBackgroundImage or not.

ducnv55 avatar Apr 17 '17 04:04 ducnv55

You can delete this code: navigationBar.setBackgroundImage(option.tabBackgroundImage, for: .default) on line 135 in file TabPageViewController.swift ))

ghost avatar Aug 20 '17 17:08 ghost