version-check icon indicating copy to clipboard operation
version-check copied to clipboard

Send token in readJson if using raw github url as file-url

Open christulin opened this issue 1 year ago • 1 comments

Drawing inspiration from this issue https://github.com/EndBug/version-check/issues/204 in addition to this comment https://github.com/EndBug/version-check/issues/147#issuecomment-1050259218.

We'd like to be able to enter the GitHub Raw URL in the file-url but have the token passed in the auth header to allow access to private repositories. In this manner we could compare the version of a feature branch against the remote main branch, and not have to rely Regular Expressions against commit messages or changes to the base branch between commits etc..

I agree the token shouldn't be passed to any website, so hopefully this hostname check suffices.

Thanks for you consideration!

@EndBug I'm happy to also make docs changes if you see fit.

christulin avatar Apr 17 '24 01:04 christulin

Hey @christulin thanks for the PR! Your idea seems great! 🚀 I'm currently away, but I'll try to test this as soon as I get back! Thanks for the patience

EndBug avatar Apr 18 '24 16:04 EndBug

Heyy @christulin , sorry for the short (6 months 💀) wait. But I finally got around reviewing this one! Going to merge, add you as contributor, and then publish <3

EndBug avatar Oct 02 '24 16:10 EndBug

@all-contributors please add @christulin for their code contribution

EndBug avatar Oct 02 '24 16:10 EndBug

@EndBug

I've put up a pull request to add @christulin! :tada:

allcontributors[bot] avatar Oct 02 '24 16:10 allcontributors[bot]