yoroi-frontend icon indicating copy to clipboard operation
yoroi-frontend copied to clipboard

Use Chrome manifest V3

Open yushih opened this issue 2 years ago • 7 comments

See the comment of https://emurgo.atlassian.net/wiki/spaces/YE/pages/739311617/Checklist+to+upgrade+to+manifest+v3 for documentation.

yushih avatar Aug 15 '22 10:08 yushih

The extension size is unreasonably big. it is 107 MB!! The current extension size is < 1 MB (dev). The final nightly size is about 30 MB. in the dev/js directory, there are a lot of assets/wasm files. Is there any reason for this?!

Details Screen Shot 2022-08-30 at 3 03 20 PM


Screen Shot 2022-08-30 at 3 02 51 PM

neuodev avatar Aug 30 '22 13:08 neuodev

@yushih For some reason, my terminal doesn't work when I try to exit the server while using stumx. I am using bash on MaxOS. I don't know if I have a problem with my terminal but we can use Concurrently for the same use case.

neuodev avatar Aug 30 '22 13:08 neuodev

The extension size is unreasonably big. it is 107 MB!! The current extension size is < 1 MB (dev). The final nightly size is about 30 MB. in the dev/js directory, there are a lot of assets/wasm files. Is there any reason for this?!

@AhmedIbrahim336 , when I try building the extension zip file, I'm getting 26.6 megabytes, which is roughly the same as in production at the moment.

vsubhuman avatar Aug 30 '22 14:08 vsubhuman

@AhmedIbrahim336 , when I try building the extension zip file, I'm getting 26.6 megabytes, which is roughly the same as in production at the moment.

@vsubhuman What about when you unzip it? The current size of the unzipped nightly build is about 50MB

neuodev avatar Aug 30 '22 19:08 neuodev

@AhmedIbrahim336 the bloating of /dev dir size is expected. Because originally, the dir only had to hold background.html, and all chunks of the background script were served by webpack-dev-server from memory. But now that mv3 allows only a JS background service worker module, it has to be written to disk (writeToDisk: true in webpack/devConfig.js).

yushih avatar Aug 31 '22 05:08 yushih

I'll take a look into the production bundle size.

yushih avatar Aug 31 '22 05:08 yushih

@AhmedIbrahim336 the bloating of /dev dir size is expected. Because originally, the dir only had to hold background.html, and all chunks of the background script were served by webpack-dev-server from memory. But now that mv3 allows only a JS background service worker module, it has to be written to disk (writeToDisk: true in webpack/devConfig.js).

@yushih Got it. If we can bundle all these assets into a separate directory this will be much cleaner.

neuodev avatar Aug 31 '22 06:08 neuodev

[autoscript] ⚠️ yushi/manifest-v3 doesn't full our branch naming convention. Should follow <tag>/<jira-ticket-id>/<short-name>

Details
  • <tag>: fix, feat, chore, refactor, test, ...
  • <jira-ticket-id>: The issue ID of JIRA all capital letters
  • <short-name>: A short and descriptive name for the branch

neuodev avatar Jul 24 '23 17:07 neuodev

SonarQube Quality Gate

Quality Gate failed

Failed condition C Reliability Rating on New Code (is worse than A)
Failed condition D Security Rating on New Code (is worse than A)
0.0% 0.0% Security Hotspots Reviewed on New Code (is less than 100%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

sonarqube-yoroi[bot] avatar Aug 21 '23 09:08 sonarqube-yoroi[bot]