Niffler icon indicating copy to clipboard operation
Niffler copied to clipboard

Rethinking how Niffler handles multiple query sources at once

Open pradeeban opened this issue 1 year ago • 1 comments

Currently, we support querying multiple sources by running ColdDataRetriever twice (or more times), by changing these parameters in the system.json.

  • NifflerID: The ID of the current execution. Default is 1. You must increment the second execution to 2, so that the logs are properly stored in niffler1.log and niffler2.log.

  • MaxNifflerProcesses: How many Niffler processes can run in parallel. Make sure each execution has its own SrcAet properly configured. Each SrcAet can run only once.

But the same Query AET can run multiple queries to multiple source AETs. So, we may rethink our approach and fix the implementation.

This will be especially useful if all the SourceAET only know and accept that one particular Niffler instance, defined by a Hostnmae, port, and AET as something like (x.x.x.x, 4242, QBNIFFLER).

pradeeban avatar May 05 '23 13:05 pradeeban

Technically, it should be possible to just run Niffler twice with the same configs except for Src AET, to get data from two different destinations.

We put checks in place to make sure Niflfler is not mistakenly run twice by two different people, getting the data mixed up.

Probably, we just need another parameter to confirm the subsequent run is intentional.

pradeeban avatar May 05 '23 13:05 pradeeban