Emilien Macchi
Emilien Macchi
/hold cancel
> I'm not sure what's going on with the unit test failures. They're not reproducible locally. ``` 2024-05-31T12:30:50.2424888Z --- FAIL: TestCreate (0.00s) 2024-05-31T12:30:50.2425466Z === RUN TestCreateMicroversion 2024-05-31T12:30:50.2426450Z --- PASS: TestCreateMicroversion...
failed locally for me
since Pierre already approved it, I'll go ahead and merge it as I'm satisfied by the CI results and the commits. Thanks for this work!
To make the build process more portable and user-configurable, I propose that we update `setup.py` to use environment variables for discovering NVSHMEM paths and linker flags. We could adopt an...
This is a good move :+1:
ping @brandon-yujie-sun
I've approved it but I need an extra pair of eyes on this one, ping @pierreprinetti