puffin icon indicating copy to clipboard operation
puffin copied to clipboard

Don't merge scopes that have non-matching dynamic data

Open hrydgard opened this issue 2 years ago • 1 comments

Scopes can have dynamic data, like this:

puffin::profile_scope!("my_scope_id", my_dynamic_data);

However, puffin's UI still happily merges blocks with different dynamic data together if merging is enabled. It would be nice with a mode that would only merge identical blocks if their dynamic data is also identical, not if it's different.

hrydgard avatar Apr 25 '22 13:04 hrydgard

Unrelated note: I wasn't aware of "dynamic data", but can perhaps utilize this to resolve #60 in some way.

MarijnS95 avatar Apr 25 '22 14:04 MarijnS95

@repi, your PR https://github.com/EmbarkStudios/puffin/pull/102 fixes this right?

TimonPost avatar Oct 18 '22 17:10 TimonPost

ah yes! didn't know we had an issue on it, was just a 10 min fix. will mark it resolved by my PR

repi avatar Oct 18 '22 17:10 repi