opensource icon indicating copy to clipboard operation
opensource copied to clipboard

Fix warnings on our crates on lib.rs

Open repi opened this issue 3 years ago • 2 comments

lib.rs has new support that runs some custom lints to validate crate definitions and metadata, we should go through all of the warnings on our Embark crates and try and fix the warnings and recommendations for our crates, full list here:

https://lib.rs/~embark-studios/dash

  • [x] tame-oauth https://github.com/EmbarkStudios/tame-oauth/pull/47
  • [x] tame-gcs https://github.com/EmbarkStudios/tame-gcs/pull/52
  • [x] gsutil https://github.com/EmbarkStudios/gsutil/pull/5
  • [x] cargo-fetcher https://github.com/EmbarkStudios/cargo-fetcher/pull/168
  • [x] cd https://github.com/EmbarkStudios/clearly-defined/pull/3
  • [x] cargo-about https://github.com/EmbarkStudios/cargo-about/pull/178
  • [x] spdx https://github.com/EmbarkStudios/spdx/pull/51
  • [x] cfg-expr https://github.com/EmbarkStudios/cfg-expr/pull/45
  • [x] krates https://github.com/EmbarkStudios/krates/pull/36
  • [x] buildkite-jobify https://github.com/EmbarkStudios/buildkite-jobify/pull/32
  • [x] nfd2 https://github.com/EmbarkStudios/nfd2/commit/d12874142583300f9981b49676de3554ab03f619 - Marked as deprecated
  • [x] spirv-tools https://github.com/EmbarkStudios/spirv-tools-rs/pull/29
  • [x] puffin, puffin_http, puffin_egui, puffin-imgui, puffin_viewer https://github.com/EmbarkStudios/puffin/pull/64
  • [x] cargo-deny https://github.com/EmbarkStudios/cargo-deny/pull/404

repi avatar Feb 02 '22 00:02 repi

Looks like we can close this one, since all tasks are complete?

celialewis3 avatar Feb 23 '22 15:02 celialewis3

oh awesome that @Jake-Shadle fixed so many already!

the listed tasks are complete but there are a bunch more on the page that should be fixed up: https://lib.rs/~embark-studios/dash

though not all of them are fixable, for example have private repos for some crates (so they are not technically open source, just published on crates.io). but many of the listings in there still think need to be followed up on to close this

repi avatar Feb 23 '22 15:02 repi