ElvUI icon indicating copy to clipboard operation
ElvUI copied to clipboard

Don't ClassColor names less than 3 characters

Open eTzmNcbkrng opened this issue 3 years ago • 6 comments

I've noticed a growing trend of people creating characters with names only two characters long. This commit prevents words like he, it, to, my, no, etc. being coloured as the class of the player that used them.

eTzmNcbkrng avatar Apr 14 '21 10:04 eTzmNcbkrng

I don't think thats necessary because you can already exclude names that you don't want to be colored in the elvui setrtings. WoWScrnShot_061321_133443

Apollyonn avatar Jun 13 '21 10:06 Apollyonn

Yeah I saw that, I was constantly adding players to it though.

eTzmNcbkrng avatar Jun 14 '21 03:06 eTzmNcbkrng

Yeah super annoying, would love to see that merged

Barsoomx avatar Jun 14 '21 10:06 Barsoomx

In order to accept this, you have to change it a bit and add the ability to completly disable it. For example add a slider to chat settings and modify the code to look something like this. If the slider is set to 0 it will be disabled. I think this is the most ideal way

if wordMatch and (E.global.chat.classColorMentionLetterThreshold > 0 and strlen(lowerCaseWord) >= E.global.chat.classColorMentionLetterThreshold) and not E.global.chat.classColorMentionExcludedNames[wordMatch] then local classColorTable = CUSTOM_CLASS_COLORS and CUSTOM_CLASS_COLORS[classMatch] or RAID_CLASS_COLORS[classMatch] end

Apollyonn avatar Jun 20 '21 16:06 Apollyonn

image

eTzmNcbkrng avatar Jul 02 '21 11:07 eTzmNcbkrng

In order to accept this, you have to change it a bit and add the ability to completly disable it.

Done

eTzmNcbkrng avatar Sep 07 '21 09:09 eTzmNcbkrng