Emmanuel Lepage Vallée

Results 242 comments of Emmanuel Lepage Vallée

> I just find the code to be a bit messy, and a refactor would make it easier to understand/maintain. I figure a refactor is vastly different from a complete...

> How would I call them on the widget init? Move `gtable.crush(ret._private, args or {})` 2 lines down and remove the `._private`. This will force all properties to be created...

> So how does the setter get called? AwesomeWM objects (both `gears.object` and `capi.object`) have meta code to make sure `obj:set_foo("bar")`, `obj.foo = "bar"` and `obj["foo"] = "bar"` are equivalent....

> Are the code examples supposed to be in the widget file? `--@DOC_wibox_widget_slider_handle_widget_EXAMPLE@` looks for a file called `tests/examples/wibox/widget/slider/handle_widget.lua` (it just converts the underscore to slashes). You can copy paste...

> Will these also add object properties? They don't add anything, they are just code examples used to generate images and (optionally) code for the doc. This allows us to...

The image is `./raw_images/AUTOGEN_wibox_widget_slider_handle_widget.svg`. It was getting generated, but empty because nothing called the `gen()` function. I copy pasted the code back and it does things: ```patch diff --git a/tests/examples/wibox/widget/slider/bar_widget.lua...

> I think the margins aren't being created by their setter functions. in the setter function I set the fallback of 0. Yeah, it will need an `for _, prop...

> The args is always nil I fixed that in the diff below by adding `args = args or {}` ```patch diff --git a/lib/wibox/widget/slider.lua b/lib/wibox/widget/slider.lua index 344f91e20..7becf2e9e 100644 --- a/lib/wibox/widget/slider.lua...

No, I need to circle back to this. But we have another PR in progress for a generc template system. It would be nice to have this merged first so...

> should it be mentioned in dev guide, @Elv13 ? Probably. But I am in vacations right now, so I don't have the means to submit a proper PR. But...