Eluna icon indicating copy to clipboard operation
Eluna copied to clipboard

Add [SpellInfo] and new method for [Player]

Open iThorgrim opened this issue 1 year ago • 3 comments

  • Add new object [SpellInfo].
  • Add player:GetSpells() for getting all learned spell.
  • Add [Global] GetSpellInfo(spell_entry) for getting SpelInfo with spell_entry.

iThorgrim avatar Mar 12 '24 22:03 iThorgrim

Looks fine, but you should at least NYI returns for the unsupported emulators

Terrorblade avatar Mar 13 '24 18:03 Terrorblade

Like mentioned in DM's, when it comes to things like new objects we need to make sure that we can have an equivalent on the other emulators to prevent API differences getting out of hand. I think @Niam5 is probably the appropriate Mangos resource to let us know if this is possible or not, or whether something needs changing to achieve 1:1.

I would however like GetSpells to be renamed to GetKnownSpells or something similar to make it a little clearer what it actually returns.

Foereaper avatar Mar 13 '24 21:03 Foereaper

We'll work on this PR and make sure it works with the other cores in the SpellInfoPR branch before merging into master

Foereaper avatar Mar 17 '24 20:03 Foereaper

I'm taking the liberty of closing this PR for the time being, as the Eluna structure is not up to date on this branch, so I'll have to update it manually.

iThorgrim avatar Apr 09 '24 09:04 iThorgrim