Eluna icon indicating copy to clipboard operation
Eluna copied to clipboard

Eluna Module Update

Open Meltie2013 opened this issue 3 years ago • 6 comments

Update Eluna to match this PR https://github.com/mangoszero/server/pull/157

Meltie2013 avatar May 18 '21 19:05 Meltie2013

@Rochet2 This PR also requires an change to the RealmD submodule (which is actually dependant on this change)

See https://github.com/mangoszero/server/pull/157

billy1arm avatar May 20 '21 19:05 billy1arm

Once TC and AC builds pass, just say when to merge.

Rochet2 avatar May 21 '21 18:05 Rochet2

Are the changes going to be on all mangos versions (one, two...)?

Rochet2 avatar May 21 '21 18:05 Rochet2

I believe it's going to be ported to all the versions after the original PR. At the moment looking at why Mangos is failed with Linux and not Windows.

This should be valid on both side.

Utf8ToUpperOnlyLatin

Nevermind, being dumb.

Meltie2013 avatar May 21 '21 19:05 Meltie2013

Btw. note that the code has "if not defined azerothcore". You probably want to revert that change in the code for the accountmgr and instead change this https://github.com/ElunaLuaEngine/Eluna/blob/8f5c4699b2531c408b615f55270541a7267c742b/ElunaIncludes.h#L135 into just sAccountMgr without the &.

Rochet2 avatar May 21 '21 19:05 Rochet2

@Rochet2 I should have it reverted soon.

Meltie2013 avatar May 22 '21 17:05 Meltie2013

This pr is no longer relevant, so closing.

Foereaper avatar Jul 27 '23 10:07 Foereaper