TwitterMediaHarvest icon indicating copy to clipboard operation
TwitterMediaHarvest copied to clipboard

[BUG] Unable to download video from Card

Open fireattack opened this issue 1 year ago • 2 comments

Describe the bug Unable to download video inside a Card.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://twitter.com/DMMTV_ANIME_PR/status/1679687160398479362
  2. Click on download button

Expected behavior Download the vid

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 114.0.5735.199

fireattack avatar Jul 14 '23 07:07 fireattack

Thanks for your report.

Card tweet parsing would be enhanced in the future version. That would be helpful if you can provide more card type tweets which you think it should be downloadable.

EltonChou avatar Jul 14 '23 21:07 EltonChou

I'd say any media_entities in result.card.legacy.binding_values.value.string_value, such as from https://twitter.com/Amamiyastaff/status/1673964451979202560

A slightly tricker case is swipeable media such as https://twitter.com/sacramusic_jp/status/1645713308995952640, where you need to make sure to order the image by slides, since their media entries are sometimes ordered differently (in this particular case, media_1 from slide 1 is using the second media in media_entities, for example).

I believe I've also seen result.card.(legacy.)binding_values.player_stream_url, but I can't find an example right now.

fireattack avatar Jul 15 '23 03:07 fireattack