elrond-wasm-rs icon indicating copy to clipboard operation
elrond-wasm-rs copied to clipboard

Published 20 hours ago • verified publisher icon ElrondNetwork

add control changes function in system sc proxy

Open SkyzoxRobin opened this issue 2 years ago • 1 comments

The function "controlChanges" is missing in the system sc proxy

SkyzoxRobin avatar Aug 26 '22 15:08 SkyzoxRobin

I will update with the property "canTransferNFTCreateRole" when the PR 812 is merged.

SkyzoxRobin avatar Aug 26 '22 15:08 SkyzoxRobin

The PR #812 has been merged, so I added the "canTransferNFTCreateRole" in the properties for the controlChanges

SkyzoxRobin avatar Dec 08 '22 14:12 SkyzoxRobin

The implementation looks good, but it is somewhat inconsistent with the rest of the system SC proxy. We use structs instead of lists of property-value pairs everywhere else.

I would create another struct that holds optionals instead of just booleans. Then we could pass that structure to controlChanges. To avoid code duplication, we can also integrate it everywhere else in the proxy as an intermediary step.

Would you like to do it, or should I take it over? It is doesn't take me long

andrei-marinica avatar Dec 08 '22 14:12 andrei-marinica