uniswap-universal-router-decoder icon indicating copy to clipboard operation
uniswap-universal-router-decoder copied to clipboard
verified publisher icon Elnaril

Add support for PERMIT2_TRANSFER_FROM_BATCH

Open Elnaril opened this issue 7 months ago • 6 comments

Issue:

This SDK does not support the Universal Router function PERMIT2_TRANSFER_FROM_BATCH yet.

Objective:

Add support for PERMIT2_TRANSFER_FROM_BATCH.

How:

  • Add encoding and decoding for this function.
  • Add docstrings to document the exposed API
  • Add unit tests:
    • encode and decode a call to this function.
    • find an actual and successful transaction on Ethereum mainnet and decode it
  • Add (or modify) an integration test using anvil to demonstrate the implementation works.

Advice:

Stay consistent with the current code style and spirit. Make sure to stay consistent with the existing unit and integration tests.
100% of new code must be covered by unit tests.
Integration tests must use Foundry Anvil and keep the structure of existing ones.
All tox and CI tests must pass for the PR to be considered.

Elnaril avatar Sep 30 '25 08:09 Elnaril

please assign me this issue :)

Kcodess2807 avatar Oct 02 '25 12:10 Kcodess2807

Ah ah! This one too!? No problem, but let's finalize the other ones first ... and give a chance to other developers as well ! 😆

Elnaril avatar Oct 02 '25 13:10 Elnaril

Hey @Elnaril, can I work on this issue?

K-Preetham-Reddy avatar Oct 05 '25 08:10 K-Preetham-Reddy

@K-Preetham-Reddy : Let's finalize first your other PR

Elnaril avatar Oct 05 '25 09:10 Elnaril

hi, looks like an interesting issue to work on, would love an assignment

SOGeKING-NUL avatar Oct 12 '25 07:10 SOGeKING-NUL

Hello @SOGeKING-NUL It's all yours now ! :)

Elnaril avatar Oct 12 '25 08:10 Elnaril