NaturesAura icon indicating copy to clipboard operation
NaturesAura copied to clipboard

unsure if serious or not, getting a number of repeated naturesaura recipe(?) big error traces in log

Open hiimrickross opened this issue 1 year ago • 2 comments

hi, while looking thru logs / hunting crashes for other things, i noticed there is big sections of recipe failures for naturesaura in there. sophisticatednaturesalexcaves.txt

is this inconsequential, or might cause problems?

hiimrickross avatar Feb 01 '24 09:02 hiimrickross

Hi! Does this also happen with just Nature's Aura and Patchouli installed?

Ellpeck avatar Mar 07 '24 14:03 Ellpeck

This issue might be caused by these functions above The JEINaturesAuraPlugin.registerItemSubtypes#registration.registerSubtypeInterpreter definition doesn't check if the return value of getEffect can be null. The return value of ItemEffectPowder.getEffect can indeed be null. JEINaturesAuraPlugin.registerItemSubtypes#registration.registerSubtypeInterpreter doesn't know how to correct handle a null return value. It seems that the return value of ItemEffectPowder.getEffect is null, and JEINaturesAuraPlugin.registerItemSubtypes#registration.registerSubtypeInterpreter is unable to process this.

https://github.com/Ellpeck/NaturesAura/blob/f2547e6555f40ae8a5d2ad5f1bc9c379dc5e50ff/src/main/java/de/ellpeck/naturesaura/items/ItemEffectPowder.java#L24-L31

https://github.com/Ellpeck/NaturesAura/blob/f2547e6555f40ae8a5d2ad5f1bc9c379dc5e50ff/src/main/java/de/ellpeck/naturesaura/compat/jei/JEINaturesAuraPlugin.java#L48-L60

AndreAugustoDev avatar Mar 11 '24 16:03 AndreAugustoDev