firefox-nordic-theme icon indicating copy to clipboard operation
firefox-nordic-theme copied to clipboard

broken in 108

Open ghost opened this issue 2 years ago • 6 comments

https://github.com/rafaelmardojai/firefox-gnome-theme/issues/504

ghost avatar Dec 15 '22 08:12 ghost

This PATCH may fix it

ghost avatar Dec 15 '22 08:12 ghost

diff --git a/theme/parts/popups.css b/theme/parts/popups.css
index 9aeff61..3a58d2b 100644
--- a/theme/parts/popups.css
+++ b/theme/parts/popups.css
@@ -128,7 +128,6 @@ panel[type="arrow"].panel-no-padding::part(content) {
 	border-radius: 5px !important;	
 	color: var(--nordic-toolbar-color) !important;
 	font: menu !important;
-	width: 100%;
 }
 .subviewbutton,
 .protections-popup-category,

ghost avatar Dec 15 '22 08:12 ghost

This was the most effective solution I found for this theme (firefox-nordic-theme)

toolbarbutton {
  width: auto !important;
}

dr-iroh avatar Dec 16 '22 00:12 dr-iroh

This was the most effective solution I found for this theme (firefox-nordic-theme)

toolbarbutton {
  width: auto !important;
}

Apparently the new update changed the width of all the buttons on the toolbar. @soracqt @EliverLara

dr-iroh avatar Dec 16 '22 00:12 dr-iroh

I've played around with the width modifications and that does seem to sort out the horizontal layout, but there seems to be some other issues with vertical centering and extension button backgrounds & borders.

jakehamilton avatar Dec 25 '22 00:12 jakehamilton

I've made some changes in a fork that seem to have corrected all of the problems as far as I can tell. Not sure if they're the cleanest or best options for fixing it, but it can hopefully be of some help to those with more experience working on themes.

The vertical alignment was fixed just by setting the height of #nav-bar-customization-target to 32px.

I think most of the issues relating to the extension buttons might revolve around a change to whichever element used to have the id #appMenu-popup; I left those selectors untouched in case they were unrelated and instead opted for adding additional selectors to the existing rules in buttons.css that target variants of toolbaritem.toolbaritem-combined-buttons.

There's also some unrelated changes for #15 in the fork that creates an additional CSS variable for the text color in popup menus.

glasket avatar Dec 28 '22 05:12 glasket