Eliza Khachatryan

Results 15 comments of Eliza Khachatryan

There are several problems with tabs raised in this issue with regard to regression. Part 1: Calcite Tabs confirmed to allow for long tab titles in the current release: https://codepen.io/elijbet/pen/zYjNpwz?editors=1010...

Here is a list of relevant Items with a similar issue. What do we think about these? @ashetland @macandcheese @jcfranco Accordion-Item Chip Combobox and Combobox-item Dropdown Input and input-date-picker Link...

I also noticed that when you drag item 2 into the first position in the list and remove item 2, it won't remove that visually either. The data is still...

> This is looking really good, nice work Eliza! > > The only issue I found is that `calciteModalOpen` and `calciteModalBeforeOpen` do not emit on page load like the rest...

Actually, I decided to rework this issue to cover all the components that need physical positioning swapped with logical (if missing support for RTL), and have multiple PRs instead of...

> @Elijbet Is the alert with `actions-end` ready for verification, and/or should we move this into the January release milestone? It's ready. Just changed the tag.

I have a lingering question regarding what happens when we close a tab. As in does closing tab 3 mean we get tab 4 selected (tab 4 contents displayed) after...

> My expectation was for the next tab to be focused and opened rather than the previous, but I could see either way as long as we are consistent 👍🏽...

Note that it is the browser's default functionality is to show the whole placeholder on active/focus, which is why it removes the applied ellipsis. But I agree that it isn't...

I wasn't aware we had components with `closed/collapsed` props instead of `open/expanded`. I don't think the `openClose` commonTest util accounts for those cases. `openPropName` currently checks for either "open" or...