Tab Wrapping GM Screen Button Behavior

[Shuggaloaf]

Environment Details

• Foundry Core Version: 0.7.9
• System & Version: 5e 1.2.4
• OS & Browser: Win 10 & All (Electron, Chrome ,FF)
• Hosting: self (Forge, Self Hosted, Electron App, etc might be relevant)

Describe the bug When the GM Screen window width is set to a narrow percentage, and there are enough tabs to wrap, the GM Screen Button wraps to the bottom line. This causes unwanted behavior when collapsed with all tabs still showing and Button appearing behind other the tabs. This can make it difficult/impossible to open the Screen.

To Reproduce Steps to reproduce the behavior: 1 Set Screen Width to something like "35" 2 Make 6 or so tabs 3 see pic above

Expected behavior Tabs should hide and GM Screen Button should always appear on top row of tabs.

Workarounds Use wider GM Screen percentage; Use less tabs; or Zoom out if using browser

Screenshots (edit: It may be hard to tell but this is while GM Screen is collapsed and at bottom of screen)

[akrigline]

I can't say I ever expected this particular issue... This is pretty low priority on my book but I'll happily review a pull request fixing it.

[Shuggaloaf]

Hey @akrigline I know, I'm going against the "typical" GM Screen style. 😉 For me having a smaller width GM Screen, but with multiple tabs, gives a much cleaner look. It could also be that I am on a high-res (4K) screen and that's a lot of screen space to take up. (So maybe a concern fo other high-res users, maybe not.)

I also concede that this would be low priority as there are workarounds like I mentioned in the OP. I actually fixed mine just by shortening some tab names.

And just to give you a visual of what I'm going for...

[akrigline]

Yeah, that makes a lot of sense. What you have there looks really nice too (side note, are those journal entries with collapsible headings from somewhere or did you DIY them?)!

What makes this hard is how to actually handle the UI in cases where there are too many tabs. They have to go somewhere, and the 'where' is a tricky problem. Any thoughts on your end how we might handle this?

[Shuggaloaf]

Thanks! Yeah I thought it looked really nice as well. Easy to navigate and still plenty of room to see the actual canvas.

The collapsible journal sections are from a mod called - wait for it - Collapsible Journal Sections. lol Works really well and is a game changer for me as I used to have map notes in a bunch of different entries because one was too long to easily find the area/room I was looking for. But now I can have them in 1 with collapsed sections.

So as far as where the tabs need to go, it seems that now, if there is 1 line of tabs, they seem disappear/collapse behind the GM screen when it is collapsed. Is that not possible with more than 1 row of tabs? If it is possible, is it not feasible because it would also hide the "GM Screen" button?

edit: Just thinking here.... does the mod look at the tab rows as just 1 row even when it wraps? If so I'm guessing it is set to drop down by a set amount of pixels when the screen is collapsed? What about increasing that value so it drops farther?