foundryvtt-gmScreen icon indicating copy to clipboard operation
foundryvtt-gmScreen copied to clipboard

Change edit icon to open external icon.

Open kristianserrano opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. It's not obvious that the edit icon opens the Journal Entry. Edit makes the user think that they can change the content of that panel, and there's no obvious way to simply open the JE.

Describe the solution you'd like Using external-link-alt or external-link-square-alt might be a more obvious choice for Journal Entries.

Describe alternatives you've considered None.

Additional context Screen Shot 2021-09-02 at 2 21 33 PM

kristianserrano avatar Sep 02 '21 18:09 kristianserrano

I'm also not happy with the "edit" icon. But this is too close to the already-common 'pop-out' use case. Any other icons come to mind for what this does?

I think at one point I had the icon match the type of document it was, but scrapped that as it caused issues.

akrigline avatar Sep 02 '21 18:09 akrigline

Maybe book-open? or eye for view

kristianserrano avatar Sep 02 '21 19:09 kristianserrano

Hmmmm. Thinking more about this, the external-link-square-alt icon you originally suggested is sufficiently different from the popout icon that i think it would be alright.

akrigline avatar Sep 13 '21 14:09 akrigline