Biomancy icon indicating copy to clipboard operation
Biomancy copied to clipboard

Feat: Bulk Digestion in Gastric Acid

Open kd8lvt opened this issue 1 year ago • 3 comments

Throw digestible item in acid, get nutrient paste out. Has a 80% efficiency when compared the the digester for balance, but the fact that you have to grow your cradle enough to get acid is also a component.

Fairly simple to change the efficiency on it, it's in AcidInteractions.

Annoyingly, neither Forge nor Minecraft give a clean way to get JUST item entities during a tick, so I had to Mixin into ItemEntity.tick()

kd8lvt avatar Oct 02 '24 21:10 kd8lvt

Implemented the changes I resolved. As for the others-

  • Particles: I wanted to do them for the visual feedback of something happening, but even after creating an entirely different particle that's just a green bubble that doesn't care where it is, (and switching to clientside of course,) still no bueno.
  • RecipeWrapper: Still unsure what you mean by this; I'm more than willing to learn, just haven't quite figured out how you'd want me to use/implement that specifically.

kd8lvt avatar Oct 04 '24 17:10 kd8lvt

RecipeWrapper: Still unsure what you mean by this; I'm more than willing to learn, just haven't quite figured out how you'd want me to use/implement that specifically.

I'm planning to phase out the use of vanilla inventory containers and my extensions of it (BehavioralInventory) in favor of simply using (neo-)forges ItemStackHandler interfaces. The recipe wrapper is just used when you need a vanilla inventory container for assembling recipes, etc.

Example:

RecipeWrapper inv = new RecipeWrapper(new ItemStackHandler(1));
inv.setItem(0, inputStack);
ItemStack resultStack = recipe.assemble(inv, level.registryAccess());

Elenterius avatar Oct 04 '24 18:10 Elenterius

Particles: I wanted to do them for the visual feedback of something happening, but even after creating an entirely different particle that's just a green bubble that doesn't care where it is, (and switching to clientside of course,) still no bueno.

no idea whats going on with that but if you feel like it you can include the removed code for the particle in the PR (or link to a branch with the code) and i will look into it at a later point. I'm mentioning this because i do want to spruce up acid fluid with bubbles.

Elenterius avatar Oct 04 '24 21:10 Elenterius

Particles: I wanted to do them for the visual feedback of something happening, but even after creating an entirely different particle that's just a green bubble that doesn't care where it is, (and switching to clientside of course,) still no bueno.

no idea whats going on with that but if you feel like it you can include the removed code for the particle in the PR (or link to a branch with the code) and i will look into it at a later point. I'm mentioning this because i do want to spruce up acid fluid with bubbles.

Will do, I've been busy with IRL stuff the last week, hence why I haven't touched it lol

Edit: I got them working in the latest batch of commits. Probably related to #151 - particles don't render through Acid without Fabulous graphics, which pretty thoroughly ruins the effect :(

kd8lvt avatar Oct 09 '24 18:10 kd8lvt

We love redundant merging! (6f01210) Woops.

kd8lvt avatar Oct 10 '24 03:10 kd8lvt