lightning

lightning copied to clipboard

During close the status of a channel is rather complex to track. Many of the outputs, whether they are direct `to_us`, `to_them` or delayed `to_us`, `to_them` or HTLC sweeps, have...

cdecker

grpc api: Same fee limit handling for keysend and pay

1

### Issue The handling of fee limits is inconsistent on different api endpoints. The lightning-pay api endpoint exposes maxfee, maxfeepercent and exemptfee fee as parameters. (https://docs.corelightning.org/reference/lightning-pay) The lightning-keysend api enpoint...

michaelWuensch

cleanup: Use the `-rpcwait` when waiting for bitcoind to warm up

3

We currently use a rather lengthy loop to wait for `bitcoind` to warm up and be ready to serve RPC calls: https://github.com/ElementsProject/lightning/blob/44d408cc87beb854bdaf60c72108bb4492cfb34b/plugins/bcli.c#L710-L749 This could be simplified if we just call...

cdecker

offers: still not getting invoice back from CLN

3

### Issue and Steps to Reproduce Even with https://github.com/ElementsProject/lightning/pull/7304 in 24.05, in our testing with LNDK we're still having some trouble getting an invoice back from CLN in multi-hop test...

orbitalturtle

meta: Should we use the discussion forum for support requests?

3

We currently don't have a non-ephemeral medium for longer discussions and support inquiries, that don't have a well-defined start and end (i.e., pressing the `Close` button on an issue). We...

cdecker

BOLT12: can't decode offer (invalid token)

4

This is public bolt12 offer of @Sjors lno1pg4y7ur9dcs8xmm4wf3k2gryv4mx2mr0wpkk2mn5ypjx7mnpw35k7m3qvehhygzndfhhyuc5pefk5mmjwvs9qun0wehk7um5rcsrwlufzdn408gvmlpgxw7rywsaq9g5a6jq6jxvapknrcucyglqevlsgqgf4k7rc5runmkuex8ue6jrj0r9jszltusclp4yd0z4mekwa7k8dfskd2ltdlfmcdnm6f0sv5jsrs6t3vkql8nav0vl6w4l44gmaf4c when I try to decode it with CLN 24.05 I get: ``` cln decode lno1pg4y7ur9dcs8xmm4wf3k2gryv4mx2mr0wpkk2mn5ypjx7mnpw35k7m3qvehhygzndfhhyuc5pefk5mmjwvs9qun0wehk7um5rcsrwlufzdn408gvmlpgxw7rywsaq9g5a6jq6jxvapknrcucyglqevlsgqgf4k7rc5runmkuex8ue6jrj0r9jszltusclp4yd0z4mekwa7k8dfskd2ltdlfmcdnm6f0sv5jsrs6t3vkql8nav0vl6w4l44gmaf4c { "code": -32602, "message": "string: invalid offer...

urza

BOLT12: CLN 24.05 can't fetch invoice from offer generated by LDK (recipient node id hiding)

1

This is @TheBlueMatt public bolt12 offer (generated by LDK): `lno1qsgqmqvgm96frzdg8m0gc6nzeqffvzsqzrxqy32afmr3jn9ggkwg3egfwch2hy0l6jut6vfd8vpsc3h89l6u3dm4q2d6nuamav3w27xvdmv3lpgklhg7l5teypqz9l53hj7zvuaenh34xqsz2sa967yzqkylfu9xtcd5ymcmfp32h083e805y7jfd236w9afhavqqvl8uyma7x77yun4ehe9pnhu2gekjguexmxpqjcr2j822xr7q34p078gzslf9wpwz5y57alxu99s0z2ql0kfqvwhzycqq45ehh58xnfpuek80hw6spvwrvttjrrq9pphh0dpydh06qqspp5uq4gpyt6n9mwexde44qv7lstzzq60nr40ff38u27un6y53aypmx0p4qruk2tf9mjwqlhxak4znvna5y` my CLN 24.05 can decode it as: ``` { "type": "bolt12 offer", "offer_id": "3886557814d09f89514b881433ad4dec732890ee0834164ce08a16b2156b7460", "offer_metadata": "0d8188d9749189a83ede8c6a62c81296", "offer_description": "", "offer_paths": [...

urza

We have long had an issue with the "Ran out of routes" error essentially covering up the real reason a payment has failed. Let's try and add some better error...

cdecker

add a function to modify localmods

1

Function gossmap_local_updatechan can be used to add changes to the gossmap that will apply only locally/temporarily. The function takes as arguments all fields inside a half_chan. The problem is that...

Lagrang3

See https://github.com/ElementsProject/lightning/pull/7406 where @ShahanaFarooqui details this! I'm merging that PR which fixes some of them, at least.

rustyrussell