lightning icon indicating copy to clipboard operation
lightning copied to clipboard

cln-plugin: add a hook builder to make use of before, after and filters

Open daywalker90 opened this issue 1 month ago • 2 comments

Mirroring https://github.com/ElementsProject/lightning/pull/8677/commits/60a0ed258f8a75ca78d1bcd6dadda0cbc4f4513b

Changelog-None

  • [x] The changelog has been updated in the relevant commit(s) according to the guidelines.
  • [x] Tests have been added or modified to reflect the changes.
  • [x] Documentation has been reviewed and updated as needed.
  • [x] Related issues have been listed and linked, including any that this PR closes.

daywalker90 avatar Nov 20 '25 10:11 daywalker90

ACK https://github.com/ElementsProject/lightning/pull/8704/commits/9a6486e153cb080c74a15666c3b08f27235d75e4

cdecker avatar Nov 24 '25 12:11 cdecker

It seems this one missed 25.12 because it wasn't linked to an issue :( added it to the milestone for the next release

madelinevibes avatar Dec 08 '25 04:12 madelinevibes

rebased after https://github.com/ElementsProject/lightning/pull/8768

daywalker90 avatar Dec 19 '25 12:12 daywalker90

CI timed out in pre-build checks in "Check source" at

contrib/pyln-proto/tests/test_invoice.py ..                              [ 13%]
Error: The operation was canceled.

no clue why. It works locally.

daywalker90 avatar Dec 19 '25 13:12 daywalker90

@daywalker90... this update re: CI from @ShahanaFarooqui in another forum might explain?

The CI is still failing, but I merged your PR since it had already passed the checks. The workflow will require further debugging, but my best guess is that the GitHub container is running out of resources due to our recently added --reruns=10 pytest option. Please disregard any CI failures unrelated to your changes until the workflow stabilizes.

madelinevibes avatar Dec 22 '25 03:12 madelinevibes

Yes, CI is consistently failing the pre-build check for all PRs, even though it passes locally (albeit taking ~100 minutes).

ShahanaFarooqui avatar Dec 22 '25 06:12 ShahanaFarooqui