lightning icon indicating copy to clipboard operation
lightning copied to clipboard

Published 20 hours ago • verified publisher icon ElementsProject

trace payment_continue and payment mods

Open JssDWt opened this issue 1 year ago • 2 comments
trafficstars

JssDWt avatar Aug 12 '24 08:08 JssDWt

Thanks @JssDWt, I've been wanting to instrument this part of the code for quite a while, and never had the muse to get started. I added #7575 on top of your change to instrument all JSON-RPC calls that plugins start, and we can likely also instrument all entrypoints to the plugin as well (rpcmethod, hook and notifications).

cdecker avatar Aug 15 '24 11:08 cdecker

@cdecker I moved the commits around a little bit. Only tracing payment_continue now, because under some circumstances it seemed that the traces got intertwined. Also incorporated your suggestion here

It now builds on the (modified) commit from #7575

JssDWt avatar Aug 16 '24 11:08 JssDWt

Rebased. And also fixed a bug where the error field would be false when there was an error and vice versa.

JssDWt avatar Oct 31 '24 13:10 JssDWt

Pretty! I missed this on the milestone, fixed now.

Rebasing now.

rustyrussell avatar Nov 12 '24 00:11 rustyrussell

This is confusing. https://github.com/ElementsProject/lightning/pull/7575 says it builds on this, this says it's now based on that. And I can't force push to this branch to rebase.

So I'm going to add to the confusion by opening another PR!

rustyrussell avatar Nov 12 '24 00:11 rustyrussell