lightning icon indicating copy to clipboard operation
lightning copied to clipboard

Compilation failure on armhf in `receive_offer`

Open cdecker opened this issue 3 years ago • 0 comments

Issue and Steps to Reproduce

Trying to build the PPA on Launchpad, for armhf (Ubuntu 22.04 only):

closingd/closingd.o closingd/closingd.c
closingd/closingd.c: In function ‘main’:
closingd/closingd.c:1009:35: error: ‘receive_offer’ reading 128 bytes from a region of size 32 [-Werror=stringop-overread]
 1009 |                                 = receive_offer(pps, chainparams,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1010 |                                                 &channel_id, funding_pubkey,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1011 |                                                 funding_wscript,
      |                                                 ~~~~~~~~~~~~~~~~
 1012 |                                                 local_wallet_index,
      |                                                 ~~~~~~~~~~~~~~~~~~~
 1013 |                                                 local_wallet_ext_key,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~
 1014 |                                                 scriptpubkey, &funding,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~~~
 1015 |                                                 funding_sats,
      |                                                 ~~~~~~~~~~~~~
 1016 |                                                 out, opener,
      |                                                 ~~~~~~~~~~~~
 1017 |                                                 our_dust_limit,
      |                                                 ~~~~~~~~~~~~~~~
 1018 |                                                 min_fee_to_accept,
      |                                                 ~~~~~~~~~~~~~~~~~~
 1019 |                                                 wrong_funding,
      |                                                 ~~~~~~~~~~~~~~
 1020 |                                                 &closing_txid,
      |                                                 ~~~~~~~~~~~~~~
 1021 |                                                 their_feerange);
      |                                                 ~~~~~~~~~~~~~~~
closingd/closingd.c:1009:35: note: referencing argument 4 of type ‘const struct pubkey *’
closingd/closingd.c:231:1: note: in a call to function ‘receive_offer’
  231 | receive_offer(struct per_peer_state *pps,
      | ^~~~~~~~~~~~~
closingd/closingd.c:1076:35: error: ‘receive_offer’ reading 128 bytes from a region of size 32 [-Werror=stringop-overread]
 1076 |                                 = receive_offer(pps, chainparams, &channel_id,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1077 |                                                 funding_pubkey,
      |                                                 ~~~~~~~~~~~~~~~
 1078 |                                                 funding_wscript,
      |                                                 ~~~~~~~~~~~~~~~~
 1079 |                                                 local_wallet_index,
      |                                                 ~~~~~~~~~~~~~~~~~~~
 1080 |                                                 local_wallet_ext_key,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~
 1081 |                                                 scriptpubkey, &funding,
      |                                                 ~~~~~~~~~~~~~~~~~~~~~~~
 1082 |                                                 funding_sats,
      |                                                 ~~~~~~~~~~~~~
 1083 |                                                 out, opener,
      |                                                 ~~~~~~~~~~~~
 1084 |                                                 our_dust_limit,
      |                                                 ~~~~~~~~~~~~~~~
 1085 |                                                 min_fee_to_accept,
      |                                                 ~~~~~~~~~~~~~~~~~~
 1086 |                                                 wrong_funding,
      |                                                 ~~~~~~~~~~~~~~
 1087 |                                                 &closing_txid,
      |                                                 ~~~~~~~~~~~~~~
 1088 |                                                 their_feerange);
      |                                                 ~~~~~~~~~~~~~~~
closingd/closingd.c:1076:35: note: referencing argument 4 of type ‘const struct pubkey *’
closingd/closingd.c:231:1: note: in a call to function ‘receive_offer’
  231 | receive_offer(struct per_peer_state *pps,
      | ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:305: closingd/closingd.o] Error 1
rm external/arm-linux-gnueabihf/libwally-core-build/src/secp256k1/libsecp256k1.la
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [debian/rules:25: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:18: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2

getinfo output

Commit: v0.12.1 tag (fda3904d8)

cdecker avatar Oct 07 '22 14:10 cdecker