lightning icon indicating copy to clipboard operation
lightning copied to clipboard

[feature-request]: New gRPC methods

Open niteshbalusu11 opened this issue 3 years ago • 3 comments
trafficstars

Issue and Steps to Reproduce

@cdecker sorry for the long list, the following methods could really help me out.

Please add/build out new gRPC methods:

  • [X] ListClosedChannels
  • [ ] openChannelAbort
  • [ ] fundChannelCancel
  • [ ] multiFundChannel
  • broadcastChainTransaction

Subscriptions:

  • [X] staticBackups
  • [X] forwards
  • channel events (opens/closes)
  • [X] payments (send/receive)
  • chain transactions
  • Subscribe to probes

niteshbalusu11 avatar Sep 26 '22 20:09 niteshbalusu11

* ListClosedChannels

This is already included with https://github.com/ElementsProject/lightning/commit/bff3b1ca8ce89f912bcf956976ce111523cac82d :muscle:

* broadcastChainTransaction

This might have happened in https://github.com/ElementsProject/lightning/commit/04e7e285d7169485a480c3ec7abd3358ef82561b :rocket:, depending on if this is what you meant..

I am going to take a leap and add two additional methods to the list..

  • [ ] listConfigs
  • [ ] paystatus

Should I open separate issues?

theborakompanioni avatar Jul 07 '23 17:07 theborakompanioni

I made the RPC methods into a check-list, and checked the ones that are already present. Some of the methods you list need disambiguation, as there is no method broadcastChainTransaction and ProbeNode. Did you copy those from another implementation, it isn't quite clear which method you need.

cdecker avatar Nov 07 '23 16:11 cdecker

I made the RPC methods into a check-list, and checked the ones that are already present. Some of the methods you list need disambiguation, as there is no method broadcastChainTransaction and ProbeNode. Did you copy those from another implementation, it isn't quite clear which method you need.

I removed probe (doesn't make sense to have that). broadcastChainTransaction just wanted to an RPC method that can take a raw tx and broadcast it.

niteshbalusu11 avatar Nov 07 '23 16:11 niteshbalusu11