lightning icon indicating copy to clipboard operation
lightning copied to clipboard

Published 20 hours ago • verified publisher icon ElementsProject

fix markdown link where text and url are swapped

Open greggzigler opened this issue 1 year ago • 4 comments

greggzigler avatar Aug 10 '22 20:08 greggzigler

Ack 68b4e4f

Thanks! This is my first PR, so I have a couple basic questions:

  1. What does it mean when one commit is approved but the other one isn't? Does it mean I should close this PR and create a new one with only the approved changes?

  2. Why would the Build fail when I only changed markdown files? And should I (somehow) re-trigger the build?

greggzigler avatar Aug 11 '22 17:08 greggzigler

Why would the Build fail when I only changed markdown files? And should I (somehow) re-trigger the build?

It is just a flaky test that the team is trying to solve step by step, you do not need to worry about that if the failure is unrelated

vincenzopalazzo avatar Aug 11 '22 17:08 vincenzopalazzo

It is just a flaky test that the team is trying to solve step by step, you do not need to worry about that if the failure is unrelated

Great. And what about my other question? Is there something wrong in the first (unapproved) commit? Is there anything I need to do in order to get this PR merged into the codebase?

greggzigler avatar Aug 11 '22 17:08 greggzigler

Ack 68b4e4f

Thanks! This is my first PR, so I have a couple basic questions:

1. What does it mean when one commit is approved but the other one isn't? Does it mean I should close this PR and create a new one with only the approved changes?

Approving the final one implies approval of the previous ones too (git is a blockchain!), so you're good.

Though I may squash them into one commit to apply them.

2. Why would the Build fail when I only changed markdown files? And should I (somehow) re-trigger the build?

rustyrussell avatar Aug 13 '22 03:08 rustyrussell