lightning icon indicating copy to clipboard operation
lightning copied to clipboard

doc: Fix `wrong_funding` description in manpage and type in schema

Open kristapsk opened this issue 1 year ago • 5 comments

It's already wrong_funding_txid in DESCRIPTION, but not SYNOPSIS.

It's currently wrong_funding in SYNOPSIS, but wrong_funding_txid in DESCRIPTION.

kristapsk avatar Jul 20 '22 10:07 kristapsk

I think you should run make with rust enable, and I do not see any hash change in the docs so maybe can be good to run also make doc-all

vincenzopalazzo avatar Jul 22 '22 23:07 vincenzopalazzo

I think you should run make with rust enable, and I do not see any hash change in the docs so maybe can be good to run also make doc-all

Done

kristapsk avatar Jul 23 '22 07:07 kristapsk

(cd plugins; cargo build --quiet --examples)
error[E0308]: mismatched types
    --> cln-grpc/src/convert.rs:1080:28
     |
1080 |             wrong_funding: c.wrong_funding.clone(), // Rule #1 for type outpoint?
     |                            ^^^^^^^^^^^^^^^^^^^^^^^ expected struct `cln_rpc::primitives::Outpoint`, found struct `pb::Outpoint`
     |
     = note: expected enum `Option<cln_rpc::primitives::Outpoint>`
                found enum `Option<pb::Outpoint>`

I think you have no rust on your system? I have no permission to push so I can't help you to compile it :/ sorry

vincenzopalazzo avatar Jul 23 '22 11:07 vincenzopalazzo

I have, did not have errors locally after I rebuilt it with rustfmt enabled. 1.61.0 on Gentoo Linux.

kristapsk avatar Jul 23 '22 12:07 kristapsk

Added a commit https://github.com/ElementsProject/lightning/pull/5444/commits/5f6b42ce0cc85c5703d67b9453135a7a14db730a to map the Option<Outpoint> in cln-rpc and cln-grpc conversions. This is the first time we had that type as an argument, hence the lack of conversion so far.

cdecker avatar Jul 27 '22 09:07 cdecker

Have this been just forgotten about?

kristapsk avatar Sep 19 '22 10:09 kristapsk

Nope, adding it to my list of PRs to shepherd through CI

cdecker avatar Sep 19 '22 12:09 cdecker

Regenerated derived files, which were outdated.

ACK https://github.com/ElementsProject/lightning/pull/5444/commits/d971c6b33f1c5ae678167fdc63e65e78306fad71

cdecker avatar Sep 19 '22 13:09 cdecker