lightning
lightning copied to clipboard
doc: Fix `wrong_funding` description in manpage and type in schema
It's already wrong_funding_txid
in DESCRIPTION, but not SYNOPSIS.
It's currently wrong_funding
in SYNOPSIS, but wrong_funding_txid
in DESCRIPTION.
I think you should run make
with rust enable, and I do not see any hash change in the docs so maybe can be good to run also make doc-all
I think you should run
make
with rust enable, and I do not see any hash change in the docs so maybe can be good to run alsomake doc-all
Done
(cd plugins; cargo build --quiet --examples)
error[E0308]: mismatched types
--> cln-grpc/src/convert.rs:1080:28
|
1080 | wrong_funding: c.wrong_funding.clone(), // Rule #1 for type outpoint?
| ^^^^^^^^^^^^^^^^^^^^^^^ expected struct `cln_rpc::primitives::Outpoint`, found struct `pb::Outpoint`
|
= note: expected enum `Option<cln_rpc::primitives::Outpoint>`
found enum `Option<pb::Outpoint>`
I think you have no rust on your system? I have no permission to push so I can't help you to compile it :/ sorry
I have, did not have errors locally after I rebuilt it with rustfmt enabled. 1.61.0 on Gentoo Linux.
Added a commit https://github.com/ElementsProject/lightning/pull/5444/commits/5f6b42ce0cc85c5703d67b9453135a7a14db730a to map the Option<Outpoint>
in cln-rpc
and cln-grpc
conversions. This is the first time we had that type as an argument, hence the lack of conversion so far.
Have this been just forgotten about?
Nope, adding it to my list of PRs to shepherd through CI
Regenerated derived files, which were outdated.
ACK https://github.com/ElementsProject/lightning/pull/5444/commits/d971c6b33f1c5ae678167fdc63e65e78306fad71