Check if funds are getting recovered on reconnect…

[adi2011]

trafficstars

Increasing the scope of test_emergencyrecover to check if it recovers the funds successfully...

[vincenzopalazzo]

Some failures unrelated to this PR

DEBUG:root:Did not find 'MEMLEAK:' in logs
------------------------------- stderr of node lightningd-2 captured in errlog file --------------------------------
commando: FATAL SIGNAL 11 (version 06b36d3)
0x55609e953d51 send_backtrace
	common/daemon.c:33
0x55609e953dfb crashdump
	common/daemon.c:46
0x7f665e3b908f ???
	/build/glibc-SzIz7B/glibc-2.31/signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x55609e9387a3 send_more_cmd
	plugins/commando.c:632
0x55609e93b270 handle_rpc_reply
	plugins/libplugin.c:669
0x55609e93bd50 rpc_read_response_one
	plugins/libplugin.c:842
0x55609e93be86 rpc_conn_read_response
	plugins/libplugin.c:862
0x55609e9f4f68 next_plan
	ccan/ccan/io/io.c:59
0x55609e9f5b70 do_plan
	ccan/ccan/io/io.c:407
0x55609e9f5bb2 io_ready
	ccan/ccan/io/io.c:417
0x55609e9f7ea5 io_loop
	ccan/ccan/io/poll.c:453
0x55609e93eb20 plugin_main
	plugins/libplugin.c:1676
0x55609e9397ab main
	plugins/commando.c:922
0x7f665e39a082 __libc_start_main
	../csu/libc-start.c:308
0x55609e93677d ???
	???:0
0xffffffffffffffff ???
	???:0
--------------------------------------------------------------------------------
DEBUG:root:BitcoinRpcProxy shut down after processing 21 requests
DEBUG:root:BitcoinRpcProxy shut down after processing 7 requests
DEBUG:root:Calling stop with arguments ()
DEBUG:root:Result for stop call: Bitcoin Core stopping
DEBUG:root:Test execution failed, leaving the test directory /tmp/ltests-8edi95df/test_commando_rune_1 intact.

CI Pointer

cc @rustyrussell :)

[niftynei]

ACK d820594be6cbc0a6edc8338d31fc676e32900229

[cdecker]

Rebased on master to pick up some flakyness fixes.

ACK https://github.com/ElementsProject/lightning/pull/5440/commits/53d9bbcb691a652a79ef5deb608eeaa7ffae6487