lightning
lightning copied to clipboard
ElementsProject
Collaborative transaction building
Takes @niftynei's dualopen collaborative transaction building and makes it available for other daemons to use.
This is to make it available for channeld to do splicing and also other code that may want to us it in the future!
This appears to duplicate a lot of code that, when changed, will cause things to slowly drift apart. Any chance of not just extracting this but also to rewire the existing uses to use interactivetx.c?
This appears to duplicate a lot of code that, when changed, will cause things to slowly drift apart. Any chance of not just extracting this but also to rewire the existing uses to use
interactivetx.c?
Yeah definitely. The plan is to make dual open use this code, cutting out its internal implementation, probably next release ish? Also a good moment for some interim tests to look for behavior changes in the refactor.
Dual open is currently the only user of interactivetx but splicing and dual close will want to use it.
Excellent, thanks @ddustin. Want me to wait for dualopend to be migrated on top of interactivetx.c or would you like to hand this PR over as is (and create an issue so we don't forget about the migration) and I can shepherd it through CI as is.
ACK with a few changes! lgtm, let's goo!
Gotcha, I'll shepherd this through CI and merge ASAP ^^
ACK https://github.com/ElementsProject/lightning/pull/5287/commits/6f1f6e788fdf56b3dddd5d8727439345762192c5