lightning icon indicating copy to clipboard operation
lightning copied to clipboard

rpc: remove channels from listpeers in listpeerchannels

Open vincenzopalazzo opened this issue 2 years ago • 2 comments

Before the PR https://github.com/ElementsProject/lightning/pull/4821 was open, I started to work on the issue https://github.com/ElementsProject/lightning/issues/4729 because the actual status of the network makes the operation slow, and my rest API is starting to begin frustrating.

So I take the good work made in the #4821 PR and I start to integrate my old branch in it hoping to have this PR read before the next release.

Fixes https://github.com/ElementsProject/lightning/issues/4729 after that, I will move on this one https://github.com/ElementsProject/lightning/issues/4734

Override https://github.com/ElementsProject/lightning/pull/4821

For now, I will give only a run in the CI to fix some eventual failures before starting to merge my work

vincenzopalazzo avatar Jan 29 '22 09:01 vincenzopalazzo

nit: 0dc1342d357d711e6d6bb255822d3bf85ec112cc claims to be deprecation commit but seems to only be testing changes

instagibbs avatar Apr 07 '22 17:04 instagibbs

claims to be deprecation commit but seems to only be testing changes

Yes, I just write the comment in the wrong way, but in this PR I updated the test, due to the deprecated API.

But this PR is still in draft and all the coming need to be reorganize, because are a little bit messy

vincenzopalazzo avatar Apr 07 '22 18:04 vincenzopalazzo

Closing in favor of https://github.com/ElementsProject/lightning/pull/5568

vincenzopalazzo avatar Sep 02 '22 22:09 vincenzopalazzo