Issue #4720 Restrict channel fee updates…

[ddustin]

trafficstars

for leased channels to be less than comitted rates for both individual channels as well as group sets. If any channel being updated is above committed limits, abort the fee setting.

[ddustin]

Thanks for the fixups, sadly tests seems not to be too happy:

• test_setchannelfee_all: might be hitting the restriction despite not being a leased channel, maybe the lease detection is not working?

• test_channel_lease_post_expiry complains about setfeerates being unavailable (call introduced in the first commit, not sure why it's not failing everywhere)

Otherwise I look forward to merging this :-)

Thanks for the comments!

I thought these would be easier to resolve once I got the test framework working on my computer (I use a Mac).

So I pivoted to doing that first, then I plan on polishing off this PR =)

[cdecker]

Wondering if we can bring this up to date and add it to the merge-train :-)

[ddustin]

Wondering if we can bring this up to date and add it to the merge-train :-)

Workin on getting all my PRs merge-train ready this week! =)

[cdecker]

Awesome, can't wait for your changes to land :rocket:

[ddustin]

Awesome, can't wait for your changes to land 🚀

This one got pretty stale 😳 -- Gonnna look at this again a little later.

[rustyrussell]

Closing this under the "too old" rule... Feel free to fix up and reopen!