bip32 should support ypub, zpub etc.

[benma]

The bip32 library only works with xpub/xprv.

If you want to use xpub/ypub/zpub etc. (see https://github.com/satoshilabs/slips/blob/master/slip-0132.md), the library gives you a hard time currently.

I currently work around it by using only the xprv/xpub versions, and then force overwriting the version bytes when serializing.

It would be great to keep the bip32 API flexible enough so that one can provide custom version bytes.

[evd0kim]

@benma hey. could you share your code?

I'm also replacing version bytes but I have

OverflowError: Invalid unsigned integer

Obviously doing something wrong.

[benma]

@engenegr sure thing:

https://github.com/digitalbitbox/bitbox02-firmware/blob/ddcdb0e03e5c5734c46876ad25eff74d22ab26a2/src/apps/btc/btc_common.c#L284-L286

[evd0kim]

@benma

Thanks a lot!

[Fonta1n3]

My opinion is libwally should not do this. bip32 has nothing to do with slip0132.

[benma]

@Fonta1n3 what is the disadvantage in supporting it?

Note that Zpub, Ypub etc. are already pervasively used by Electrum and compatible wallets. If it is not supported by the library, weird workarounds like the one I linked above are necessary.

[evd0kim]

@Fonta1n3

Actually I couldn't manage libwally working with zpub even with substituting version bytes. I would be grateful if you could say how I can import zpub and derive native segwit addresses.

[Fonta1n3]

@Fonta1n3

Actually I couldn't manage libwally working with zpub even with substituting version bytes. I would be grateful if you could say how I can import zpub and derive native segwit addresses.

This is what i use to convert:

https://github.com/Fonta1n3/FullyNoded/blob/master/FullyNoded/Helpers/Xpub%20Converter/XpubConverter.swift

[benma]

@Fonta1n3 are you using libwally-core in this project? If so, I don't understand why you prefer to re-implement xpub encoding almost completely than having it be supported upstream.

[evd0kim]

@Fonta1n3 Thank you. I see I have to replace checksum also.