elementsproject.github.io icon indicating copy to clipboard operation
elementsproject.github.io copied to clipboard

DynaFed note for con_max_block_sig_size

Open opacey opened this issue 2 years ago • 4 comments

Included a note that the signature size constant under DynaFed is 77, rather than 74 prior to DynaFed. The formula for con_max_block_sig_size is affected. The guide doesnt yet use DynaFed so this may not be the most appropriate place for this note, feel free to reject it and put in a more appropriate location.

opacey avatar Apr 01 '22 18:04 opacey

Thanks @opacey - I will check with the elements team who did Dyna fed and merge when I've had this confirmed. Thanks for the Pull Request and drawing attention to it.

wintercooled avatar Apr 05 '22 09:04 wintercooled

Where did you get the 77 from?

stevenroose avatar Apr 05 '22 13:04 stevenroose

Only from a process of trial and error. 77 seems to work in place of 74 in the pre-dynafed formula when applied to custom chains. Smaller values cause errors, and larger dont - this was the smallest which worked so I assume it is correct. However perhaps the formula itself is now different and it is only coincidence that 77 lands on a big enough final value. Sorry, should have been more clear in the original comment that this was speculation.

opacey avatar Apr 05 '22 14:04 opacey

@stevenroose - is this ok to merge after the conversation above or is there a set formula that derives the figure?

wintercooled avatar Dec 08 '22 11:12 wintercooled