element icon indicating copy to clipboard operation
element copied to clipboard

Select: Add default value to loadingText

Open obregonia1 opened this issue 2 years ago • 3 comments

Please make sure these boxes are checked before submitting your PR, thank you!

  • [x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • [x] Make sure you are merging your commits to dev branch.
  • [x] Add some descriptions and refer relative issues for you PR.

According to Document, default value of loadingText is 'Loading'. But that default value is not exist. image

obregonia1 avatar Sep 08 '22 02:09 obregonia1

其实他是设置了默认值,可以看下:

https://github.com/ElemeFE/element/blob/2c4ac8099c7c04e1b89a6d31f3d3fbc01334a971/packages/select/src/select.vue#L208

https://github.com/ElemeFE/element/blob/2c4ac8099c7c04e1b89a6d31f3d3fbc01334a971/src/locale/lang/en.js#L62

https://github.com/ElemeFE/element/blob/2c4ac8099c7c04e1b89a6d31f3d3fbc01334a971/src/locale/lang/zh-CN.js#L62

这里他用了国际化处理了默认文本,感觉这样处理比加默认的会好,假如现在加了默认值,就不会走后面国际化了,所以还是不建议这么修改。

wangdaodao avatar Sep 08 '22 07:09 wangdaodao

@wangdaodao Thanks!! Is that means setting default language to English better?

obregonia1 avatar Sep 09 '22 22:09 obregonia1

I think it would be better to set the default language.

wangdaodao avatar Sep 13 '22 01:09 wangdaodao