element
element copied to clipboard
Select: Add default value to loadingText
Please make sure these boxes are checked before submitting your PR, thank you!
- [x] Make sure you follow Element's contributing guide (中文 | English | Español | Français).
- [x] Make sure you are merging your commits to
dev
branch. - [x] Add some descriptions and refer relative issues for you PR.
According to Document, default value of loadingText
is 'Loading'. But that default value is not exist.
其实他是设置了默认值,可以看下:
https://github.com/ElemeFE/element/blob/2c4ac8099c7c04e1b89a6d31f3d3fbc01334a971/packages/select/src/select.vue#L208
https://github.com/ElemeFE/element/blob/2c4ac8099c7c04e1b89a6d31f3d3fbc01334a971/src/locale/lang/en.js#L62
https://github.com/ElemeFE/element/blob/2c4ac8099c7c04e1b89a6d31f3d3fbc01334a971/src/locale/lang/zh-CN.js#L62
这里他用了国际化处理了默认文本,感觉这样处理比加默认的会好,假如现在加了默认值,就不会走后面国际化了,所以还是不建议这么修改。
@wangdaodao Thanks!! Is that means setting default language to English better?
I think it would be better to set the default language.