libelektra icon indicating copy to clipboard operation
libelektra copied to clipboard

bindings/rust: update bindgen version

Open horenso opened this issue 2 years ago • 7 comments
trafficstars

Update bindgen for rust bindings to 0.66.1 #4989.

bindgen changed some defaults regarding the equality of usize and size_t. They added the option .size_t_is_usize(true) but made it default true in a later version. When bumping the bindgen version the error goes away. Read more about this in this issue and also here.

Basics

  • [x] Short descriptions of your changes are in the release notes (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_) Please always add them to the release notes.
  • [x] Details of what you changed are in commit messages (first line should have module: short statement syntax)
  • [x] References to issues, e.g. close #X, are in the commit messages.
  • [ ] The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • [x] The PR is rebased with current master.

Checklist

  • [ ] I added unit tests for my code
  • [ ] I fully described what my PR does in the documentation (not in the PR description)
  • [ ] I fixed all affected documentation (see Documentation Guidelines)
  • [ ] I fixed all affected decisions (see Decision Process)
  • [ ] I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • [ ] I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • [ ] I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • [x] Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • [ ] Add the "ready to merge" label if everything is done and no further pushes are planned by you.

horenso avatar Aug 20 '23 19:08 horenso

Coverage Status

coverage: 99.913% (-0.001%) from 99.914% when pulling bde799dbe2c130cd9d941b596934f4c6acecb418 on fix-rust-binding into dbbe4ae4f669c322a8f95f59112d3f5fc370bbd9 on master.

coveralls avatar Aug 20 '23 21:08 coveralls

Thx, worked for me, I published the 0.11.1 packages.

Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using.

I created https://github.com/ElektraInitiative/opensesame/issues/67

markus2330 avatar Aug 21 '23 04:08 markus2330

Thx, worked for me, I published the 0.11.1 packages.

Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using.

With the new release everything is working now :+1:

fel115 avatar Aug 21 '23 09:08 fel115

Is it expected that the macOS builds don't work or how can I fix them? Should we close this issue when https://github.com/ElektraInitiative/opensesame/issues/67 is done?

horenso avatar Aug 21 '23 09:08 horenso

Only the Jenkins job is non-optional. The error there seems to be a spurious problem. It can be retriggered with commenting jenkins build libelektra please.

@atmaxinger will you review and merge?

markus2330 avatar Aug 21 '23 10:08 markus2330

jenkins build libelektra please

markus2330 avatar Aug 21 '23 10:08 markus2330