libelektra icon indicating copy to clipboard operation
libelektra copied to clipboard

Restore whitespaces in build directory name on jenkins

Open tmakar opened this issue 1 year ago • 5 comments

With this PR (https://github.com/ElektraInitiative/libelektra/pull/4895) we have introduced the go binding into our main repo. Go seems to have issue with spaces in any folder names etc. so it fails on builds / tests, etc. As we are using build directory as our build directory name and it has a space in the name it will lead to issues with go. We have therefore removed this whitespace now.

return [(testName): {
    stage(testName) {
      withDockerEnv(image, dockerOpts) {
        // we use a space in the directory to test if paths are
        // properly escaped
        def buildDir='build directory'

With this issue the removal of whitespaces should be restored again. (we use a space in the directory to test if paths are properly escaped).

tmakar avatar May 11 '23 09:05 tmakar

Thanks for creating the issue.

What is the upstream bug? Otherwise we don't know when we can revert this change. The one I found https://github.com/golang/go/issues/1413 is already fixed?

markus2330 avatar May 11 '23 11:05 markus2330

Thanks for creating the issue.

What is the upstream bug? Otherwise we don't know when we can revert this change. The one I found golang/go#1413 is already fixed?

I took a look at https://github.com/golang/go/issues/1413. This one is about GOROOT. The one we need is https://github.com/golang/go/issues/16455, but it also seems to be "fixed". The solution seems to be to escape the name which contains spaces (generated pkg-config file) with \.

tmakar avatar May 11 '23 12:05 tmakar

Doesn't sound too hard, can you apply this fix for us?

markus2330 avatar May 11 '23 17:05 markus2330

Doesn't sound too hard, can you apply this fix for us?

Sure, will do :wink:

tmakar avatar May 11 '23 20:05 tmakar

fix depends on #4924

markus2330 avatar May 14 '23 09:05 markus2330

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar May 14 '24 01:05 github-actions[bot]

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar May 28 '24 01:05 github-actions[bot]