Open
markus2330
opened this issue 3 years ago
•
0 comments
Basics
[ ] Short descriptions of your changes are in the release notes
(added as entry in doc/news/_preparation_next_release.md which
contains _(my name)_)
Please always add something to the release notes.
[ ] Details of what you changed are in commit messages
(first line should have module: short statement syntax)
[ ] References to issues, e.g. close #X, are in the commit messages.
[ ] The buildservers are happy. If not, fix in this order:
[ ] add a line in doc/news/_preparation_next_release.md
[ ] reformat the code with scripts/dev/reformat-all
[ ] make all unit tests pass
[ ] fix all memleaks
[ ] The PR is rebased with current master.
Checklist
[ ] I added unit tests for my code
[ ] I fully described what my PR does in the documentation
(not in the PR description)
[ ] I fixed all affected documentation
[ ] I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
[ ] I updated all meta data (e.g. README.md of plugins and METADATA.ini)
[ ] I mentioned every code not directly written by me in reuse syntax
Review
[ ] Documentation is introductory, concise, good to read and describes everything what the PR does