libelektra icon indicating copy to clipboard operation
libelektra copied to clipboard

qt-gui: metadata name not shown

Open markus2330 opened this issue 4 years ago • 13 comments

Probably since keyname overhaul (which added the meta: namespace to metadata) the metadata name is now shown (the value still works). E.g. I use:

kdb meta-set /sw/app/current/#0/server/port type short
kdb qt-gui

then I navigate to spec: -> sw app -> current -> #0 -> server -> port and in the metadata window "Metakey Value" with short is shown but "Metakey Name" is blank. It should read type (or meta:/type).

grafik

@0003088 do you have time to look at it?

Btw. is there some way to change the font size of the qt-gui?

markus2330 avatar Mar 09 '21 11:03 markus2330

The namespace for metadata is called meta:/ not metadata:/

kodebach avatar Mar 09 '21 11:03 kodebach

I could not check it out in detail yet, but does this still work?

m_key.currentMeta ().getName ()

0003088 avatar Mar 09 '21 13:03 0003088

Thank you for the quick response. Yes, afaik it should still work but it now returns meta:/metakey.

markus2330 avatar Mar 09 '21 16:03 markus2330

I found the reason why it's not working. The question is, should the key be shown in the gui with or without the prefix?

0003088 avatar Apr 22 '21 14:04 0003088

Thank you so much, great :1st_place_medal:

I would not show it when editing metakeys as it is only a source of errors (any other namespace is not allowed anyway). When showing it in the main window we can consider showing meta:/ as imho it is not immediately obvious that meta-data is shown in the bottom split window and the "Metakey Name" title is quite small.

markus2330 avatar Apr 22 '21 14:04 markus2330

Btw. I get two messages when using qt-gui, the first one seemingly related to metadata:

qrc:/qml/NewMetaKey.qml:58: ReferenceError: user is not defined
qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow), sequence: 803, resource id: 10823870, major code: 40 (TranslateCoords), minor code: 0

markus2330 avatar Apr 22 '21 15:04 markus2330

I'm sorry for the delay. As I said earlier, I found the reason for the bug and corrected it. But when I tested the fix I noticed that I could not edit the metakeys, they are always overwritten in the threeway merge. I do not think this has anything to do with the display bug. Do you have any idea why the merger behaves like that?

0003088 avatar May 14 '21 06:05 0003088

I don't think we changed the old C++ merger in any way, so probably the merging you tested also did not work before. Maybe this is now a good opportunity to use @dominicjaeger's new 3 way merger instead? @dominicjaeger do you have time to do the migration or to help with it?

markus2330 avatar May 15 '21 06:05 markus2330

I think we started introducting the C merge in the qt-gui already? But I'll have to look up how far we came...

dominicjaeger avatar May 15 '21 07:05 dominicjaeger

@dominicjaeger thank you for the quick response! If we already use your implementation consider https://github.com/ElektraInitiative/libelektra/issues/3696#issuecomment-841030473 as first bug report :wink:

markus2330 avatar May 15 '21 08:05 markus2330

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

stale[bot] avatar May 31 '22 03:05 stale[bot]

I closed this issue now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

stale[bot] avatar Jun 18 '22 20:06 stale[bot]

Bug still present for me.

markus2330 avatar Jun 22 '22 13:06 markus2330

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar Jan 22 '24 01:01 github-actions[bot]

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar Feb 06 '24 01:02 github-actions[bot]