libelektra icon indicating copy to clipboard operation
libelektra copied to clipboard

make mount not fail if mp exists

Open markus2330 opened this issue 8 years ago • 12 comments

If someone tries to mount something that is mounted already, we should not fail. (If it would do exactly the same action)

Affected:

  • [ ] mount (the script elektra-mount is basically already a workaround for it)
  • [ ] global-mount see #1301 src/plugins/conditionals/README.md
  • [ ] elektra-mountcan be removed then

Unclear:

  • [ ] do we need an option to disable this behavior?

markus2330 avatar Jan 30 '17 13:01 markus2330

I have set the milestone to 0.8.21 because it should be part of LCDproc release.

We also need this feature for #1374 and #1663

markus2330 avatar Oct 29 '17 09:10 markus2330

A simple way to implement that feature would be to have a -f option which cuts the mountpoint's config before doing the mount.

If this is not a good way, we should rather move this feature to 0.8.22.

markus2330 avatar Dec 17 '17 17:12 markus2330

With --strategy preserve this works now for normal mounts.

markus2330 avatar Jan 26 '19 21:01 markus2330

@Chemin1 It would be great to have a fully working preserve strategy, so that this finally correctly works for mount and global-mount.

markus2330 avatar Oct 29 '19 16:10 markus2330

Sorry, actually we need "--strategy unchanged". And this should also be default for mounting.

The strategy is actually very simple: It only succeeds if ours, theirs and base is the same.

markus2330 avatar Oct 29 '19 16:10 markus2330

I'll have to take a closer look at how that works, as I did not even know that mounting has strategies until now.

Looking at our, their and base: Is this related to the install-config-file script that we talked about? I mount a file and get the base and our version. I mount the same file again (this is now their) with strategy unchanged and the mount succeeds?

dominicjaeger avatar Oct 29 '19 17:10 dominicjaeger

I'll have to take a closer look at how that works, as I did not even know that mounting has strategies until now.

Basically every tool that writes more than a single key (in this case merging is trivial) different strategies are useful. So also kdb shell would profit from having 3-way merging integrated.

markus2330 avatar Oct 30 '19 07:10 markus2330

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

stale[bot] avatar Oct 29 '20 08:10 stale[bot]

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

stale[bot] avatar Oct 30 '21 04:10 stale[bot]

Project would be together with #1322.

markus2330 avatar Mar 15 '22 08:03 markus2330

@flo91 Having idempotency in mounting would be essential.

markus2330 avatar Aug 01 '22 12:08 markus2330

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar Feb 20 '24 01:02 github-actions[bot]

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar Mar 05 '24 01:03 github-actions[bot]