Update build system to fail more quickly
Update GitHub workflows to fail quickly on linting errors before running the more time-consuming functional tests.
Or, you can separate the test to a different workflow to identify which part is failing more clearly
@kiyoon can you please explain the differences between these three instances of the ruff linting checks?
- https://github.com/Electrostatics/pdb2pqr/blob/9dd79cb9589ea8fac701dc40a70698baa7dd009e/.github/workflows/python-package.yml#L30
- https://github.com/Electrostatics/pdb2pqr/blob/9dd79cb9589ea8fac701dc40a70698baa7dd009e/.github/workflows/check-styles.yml#L12
- https://github.com/Electrostatics/pdb2pqr/blob/9dd79cb9589ea8fac701dc40a70698baa7dd009e/.github/workflows/check-styles.yml#L37
- It's a syntax error check. It already existed in this project in the CI with flake8, so I kept the same rules.
- You can fix by
ruff format .(apply ruff formatter) - You can fix by
ruff check --select I --fix .(fix ruff import sorting lint)
So 2, 3 are not as important as 1.
If you go in the action, there is a summary of the run where you can see the diff output of how you would fix them. Currecntly they all pass so there's no output here
Yes, I understand how to view the output. I was just asking why there were 3 different linting tests. It seems like the first test duplicates the other two.
The first test is completely different from the other two, but if you wish you can combine all of them in one. The problem is that there are important tests and there are just style checks. If too many things are combined, maybe it's hard to review others code and ask them to fix stuff, for that I preferred separated tests