apbs icon indicating copy to clipboard operation
apbs copied to clipboard

Mac Silicon support

Open kiyoon opened this issue 11 months ago • 10 comments

Is there a chance to make a release with macOS arm64 binary? I can't seem to make it work. Thank you!

kiyoon avatar Mar 21 '24 03:03 kiyoon

If the architecture you're looking for isn't on https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories, then I'm not sure we can support it. I don't have access to a Mac OS ARM64 system.

sobolevnrm avatar Mar 21 '24 04:03 sobolevnrm

@sobolevnrm The M1 processor is what I want and is available!

kiyoon avatar Mar 21 '24 04:03 kiyoon

Hi, when can I expect to see the support? Thank you.

kiyoon avatar Apr 23 '24 01:04 kiyoon

Hi,

Thank you for the correction -- that certainly makes it an easier task. I'm replying so you knew we saw your updated request, but I am not sure when exactly we'll release a version supporting M1. @sobolevnrm may have more to say.

Best regards, Jay

jbardhan avatar Apr 24 '24 03:04 jbardhan

Hi, when can I expect to see the support? Thank you.

The short answer may be "never" if we can't get additional support (financial or volunteer) for this project. I'm sorry--that is probably not the answer you were looking for. I will continue to try to find the time for this but am not sure when I'll get to it.

sobolevnrm avatar Apr 24 '24 04:04 sobolevnrm

@kiyoon I've created Homebrew formula for APBS 3.4.1. Now you can install apbs binary on Apple silicon with brew install brewsci/bio/apbs:beer:

YoshitakaMo avatar Jul 29 '24 01:07 YoshitakaMo

@YoshitakaMo Thank you, this is amazing!!

In APBS release in this repo, there's share/apbs/tools/bin directory with a few useful cli tools included as well. In my case I use multivalue. Is there a chance this can also be included?

kiyoon avatar Jul 29 '24 01:07 kiyoon

@kiyoon

Is there a chance this can also be included?

Yes!! The tools were not built during the last installation (3.4.1_1) because I've turned it off -DBUILD_TOOLS=OFF. Now I've regenerated the Homebrew bottle with -DBUILD_TOOLS=ON. apbs version 3.4.1_2 is now available. Try brew update ; brew upgrade brewsci/bio/apbs You may add PATH to use them (because one of the names of the binaries was so common that I was afraid of conflicting with other Homebrew binaries.)

==> Caveats
==> apbs
Some useful tools have been also installed in /opt/homebrew/opt/apbs/share/apbs/tools.
You may want to add the following to your .bashrc or .zshrc to use these tools:
  export APBS_TOOLS_HOME=$(brew --prefix)/opt/apbs/share/apbs/tools/
  export PATH=${PATH}:${APBS_TOOLS_HOME}/bin
==> Summary
🍺  /opt/homebrew/Cellar/apbs/3.4.1_2: 662 files, 88.3MB, built in 17 seconds

YoshitakaMo avatar Jul 29 '24 02:07 YoshitakaMo

@YoshitakaMo This is perfect! I confirmed it's running on my machine with no problem. Thanks a lot for your contribution!!

@sobolevnrm You can close the issue now if you don't plan to add support. However, I think you might want to add the official binaries in the future. Either way, I'm happy now. :)

kiyoon avatar Jul 29 '24 06:07 kiyoon