mojang-api icon indicating copy to clipboard operation
mojang-api copied to clipboard

v2 returns invalid error codes

Open egorprnn opened this issue 4 years ago • 5 comments

If we reach the set limit for obtaining information for a certain period of time, v2 api returns 404 instead of 429, in v1 everything is fine

image image

egorprnn avatar May 27 '20 05:05 egorprnn

Thanks will investigate.

Electroid avatar May 27 '20 16:05 Electroid

This happens with absolutely all errors.

egorprnn avatar Aug 19 '20 16:08 egorprnn

Thanks will investigate.

Will be nice to get this fixed, this api is almost non usable, because of that.

andreasdc avatar Apr 17 '22 17:04 andreasdc

Thanks will investigate.

Currently mojang is down and your api shows users as offline.

andreasdc avatar May 20 '22 00:05 andreasdc

{ "code": 404, "error": "Not Found", "reason": "No user with the name 'test' was found" }

While mojang right now: {"error":"Internal Server Error","errorMessage":"The server encountered an unexpected condition which prevented it from fulfilling the request"}

andreasdc avatar May 20 '22 00:05 andreasdc

Sorry this took so long, fixed in https://github.com/Electroid/mojang-api/commit/991e1e9850220cf2124a2d7a7375b52385507ea3

Electroid avatar Nov 26 '22 21:11 Electroid

Sorry this took so long, fixed in 991e1e9

Too long :D

andreasdc avatar Nov 26 '22 22:11 andreasdc